pkg/analyzer/lib/src/generated/element_resolver.dart - Issue 1215053003: Compute mixin application constructors in the ClassElement.constructors getter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/element_resolver.dart

Issue 1215053003: Compute mixin application constructors in the ClassElement.constructors getter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/generated/element_resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/element_resolver.dart b/pkg/analyzer/lib/src/generated/element_resolver.dart

index c047654d1615bf7ad186ea846969b02aa9f7ec4d..b93931f940e6ffe92b5622d00da32b6335e92823 100644

--- a/pkg/analyzer/lib/src/generated/element_resolver.dart

+++ b/pkg/analyzer/lib/src/generated/element_resolver.dart

@@ -1049,7 +1049,7 @@ class ElementResolver extends SimpleAstVisitor<Object> {

ConstructorElement element =

superType.lookUpConstructor(superName, _definingLibrary);

if (element == null ||

- (!enclosingClass.mixinErrorsReported &&

+ (!enclosingClass.doesMixinLackConstructors &&

!enclosingClass.isSuperConstructorAccessible(element))) {

if (name != null) {

_resolver.reportErrorForNode(

« no previous file with comments | « pkg/analyzer/lib/src/generated/element.dart ('k') | pkg/analyzer/lib/src/generated/error_verifier.dart » ('j') | no next file with comments »