Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: platform_tools/android/gyp/skia_android.gypi

Issue 1215023017: Update Android Apps to use gradle (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: platform_tools/android/gyp/skia_android.gypi
diff --git a/platform_tools/android/gyp/skia_android.gypi b/platform_tools/android/gyp/skia_android.gypi
index e8bf1c3150d221c4e9a2ffa569edb4a81c5e3310..c7218a78a044c4256105e8b24897abf52487e222 100644
--- a/platform_tools/android/gyp/skia_android.gypi
+++ b/platform_tools/android/gyp/skia_android.gypi
@@ -48,7 +48,7 @@
# libraries to copy, this will cause an error in Make, but the app will
# still build.
{
- 'destination': '<(PRODUCT_DIR)/android/SampleApp/libs/<(android_arch)',
+ 'destination': '<(android_base)/apps/sample_app/src/main/libs/<(android_arch)',
'conditions': [
[ 'skia_shared_lib', {
'files': [
@@ -69,40 +69,25 @@
'dependencies': [
'CopySampleAppDeps',
],
- 'variables': {
- 'ANDROID_SDK_ROOT': '<!(echo $ANDROID_SDK_ROOT)',
- # the ninja generator treats PRODUCT_DIR as a relative path to the
- # gyp directory but android ant build wants a path relative to the
- # build.xml file so we do that adjustment here.
- 'ANDROID_OUT': '../../<(PRODUCT_DIR)/android/SampleApp'
- },
'actions': [
{
'action_name': 'SampleApp_apk',
'inputs': [
- '<(android_base)/app/AndroidManifest.xml',
- '<(android_base)/app/build.xml',
- '<(android_base)/app/project.properties',
- '<(android_base)/app/jni/com_skia_SkiaSampleRenderer.h',
- '<(android_base)/app/jni/com_skia_SkiaSampleRenderer.cpp',
- '<(android_base)/app/src/com/skia/SkiaSampleActivity.java',
- '<(android_base)/app/src/com/skia/SkiaSampleRenderer.java',
- '<(android_base)/app/src/com/skia/SkiaSampleView.java',
+ '<(android_base)/apps/sample_app/src/main/AndroidManifest.xml',
+ '<(android_base)/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.h',
+ '<(android_base)/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp',
+ '<(android_base)/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java',
+ '<(android_base)/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java',
+ '<(android_base)/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java',
],
'outputs': [
- '<(PRODUCT_DIR)/../android/SampleApp/bin/SampleApp.apk',
+ '<(android_base)/apps/sample_app/build',
],
'action': [
- 'ant',
- '-quiet',
- '-f',
- '<(android_base)/app/build.xml',
- '-Dout.dir=<(ANDROID_OUT)/bin',
- '-Dgen.absolute.dir=<(ANDROID_OUT)/gen',
- '-Dnative.libs.absolute.dir=<(ANDROID_OUT)/libs',
- '-Dout.final.file=<(ANDROID_OUT)/bin/SampleApp.apk',
- '-Dsdk.dir=<(ANDROID_SDK_ROOT)',
- 'debug',
+ '<(android_base)/apps/gradlew',
+ ':sample_app:assembleDebug',
+ '-p<(android_base)/apps/sample_app',
+ '-PsuppressNativeBuild',
],
},
],
@@ -122,7 +107,7 @@
# libraries to copy, this will cause an error in Make, but the app will
# still build.
{
- 'destination': '<(PRODUCT_DIR)/android/VisualBench/libs/<(android_arch)',
+ 'destination': '<(android_base)/apps/visualbench/src/main/libs/<(android_arch)',
'conditions': [
[ 'skia_shared_lib', {
'files': [
@@ -143,36 +128,21 @@
'dependencies': [
'CopyVisualBenchDeps',
],
- 'variables': {
- 'ANDROID_SDK_ROOT': '<!(echo $ANDROID_SDK_ROOT)',
- # the ninja generator treats PRODUCT_DIR as a relative path to the
- # gyp directory but android ant build wants a path relative to the
- # build.xml file so we do that adjustment here.
- 'ANDROID_OUT': '../../<(PRODUCT_DIR)/android/VisualBench/'
- },
'actions': [
{
'action_name': 'SkiaVisualBench_apk',
'inputs': [
- '<(android_base)/visualbench/AndroidManifest.xml',
- '<(android_base)/visualbench/build.xml',
- '<(android_base)/visualbench/project.properties',
- '<(android_base)/visualbench/src/com/skia/VisualBenchActivity.java',
+ '<(android_base)/apps/visualbench/src/main/AndroidManifest.xml',
+ '<(android_base)/apps/visualbench/src/main/java/com/skia/VisualBenchActivity.java',
],
'outputs': [
- '<(PRODUCT_DIR)/../android/VisualBench/bin/VisualBench.apk',
+ '<(android_base)/apps/visualbench/build',
],
'action': [
- 'ant',
- '-quiet',
- '-f',
- '<(android_base)/visualbench/build.xml',
- '-Dout.dir=<(ANDROID_OUT)/bin',
- '-Dgen.absolute.dir=<(ANDROID_OUT)/gen',
- '-Dnative.libs.absolute.dir=<(ANDROID_OUT)/libs',
- '-Dout.final.file=<(ANDROID_OUT)/bin/VisualBench.apk',
- '-Dsdk.dir=<(ANDROID_SDK_ROOT)',
- 'debug',
+ '<(android_base)/apps/gradlew',
+ ':visualbench:assembleDebug',
+ '-p<(android_base)/apps/visualbench',
+ '-PsuppressNativeBuild',
],
},
],

Powered by Google App Engine
This is Rietveld 408576698