Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1215023017: Update Android Apps to use gradle (Closed)

Created:
5 years, 5 months ago by djsollen
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update Android Apps to use gradle This CL replaces ant with gradle for the task of building APKs. The primary driver of this change is that it now allow us to develop and test our apps using Android Studio. DOCS_PREVIEW= https://skia.org/?cl=1215023017 Committed: https://skia.googlesource.com/skia/+/425535f1626932e4e22f61a2571f9c3c2b1c5977 Committed: https://skia.googlesource.com/skia/+/d18b861061253c8691949379546a7f96c9e251c9

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : mips support #

Patch Set 4 : cleanup #

Patch Set 5 : copyright header #

Patch Set 6 : onlyIf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -2018 lines) Patch
M .gitignore View 2 chunks +7 lines, -0 lines 0 comments Download
D platform_tools/android/app/AndroidManifest.xml View 1 chunk +0 lines, -22 lines 0 comments Download
D platform_tools/android/app/build.xml View 1 chunk +0 lines, -61 lines 0 comments Download
D platform_tools/android/app/jni/AndroidKeyToSkKey.h View 1 chunk +0 lines, -35 lines 0 comments Download
D platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.h View 1 2 3 4 5 1 chunk +0 lines, -164 lines 0 comments Download
D platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp View 1 chunk +0 lines, -384 lines 0 comments Download
D platform_tools/android/app/project.properties View 1 chunk +0 lines, -14 lines 0 comments Download
D platform_tools/android/app/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
D platform_tools/android/app/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
D platform_tools/android/app/res/layout/layout.xml View 1 chunk +0 lines, -17 lines 0 comments Download
D platform_tools/android/app/res/menu/action_bar.xml View 1 chunk +0 lines, -75 lines 0 comments Download
D platform_tools/android/app/res/values/strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
D platform_tools/android/app/src/com/skia/SkiaSampleActivity.java View 1 chunk +0 lines, -279 lines 0 comments Download
D platform_tools/android/app/src/com/skia/SkiaSampleRenderer.java View 1 chunk +0 lines, -113 lines 0 comments Download
D platform_tools/android/app/src/com/skia/SkiaSampleView.java View 1 chunk +0 lines, -306 lines 0 comments Download
A platform_tools/android/apps/build.gradle View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/build.gradle View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/jni/AndroidKeyToSkKey.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.h View 5 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/res/layout/layout.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/res/menu/action_bar.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/sample_app/src/main/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A platform_tools/android/apps/settings.gradle View 1 chunk +2 lines, -0 lines 0 comments Download
A platform_tools/android/apps/visualbench/build.gradle View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A + platform_tools/android/apps/visualbench/src/main/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/visualbench/src/main/jni/main.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M platform_tools/android/bin/android_install_app View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 2 5 chunks +27 lines, -50 lines 0 comments Download
D platform_tools/android/visualbench/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D platform_tools/android/visualbench/build.xml View 1 chunk +0 lines, -61 lines 0 comments Download
D platform_tools/android/visualbench/jni/SkOSWindow_AndroidNative.cpp View 1 chunk +0 lines, -187 lines 0 comments Download
D platform_tools/android/visualbench/jni/main.cpp View 1 2 1 chunk +0 lines, -134 lines 0 comments Download
D platform_tools/android/visualbench/project.properties View 1 chunk +0 lines, -14 lines 0 comments Download
D platform_tools/android/visualbench/src/com/skia/VisualBenchActivity.java View 1 chunk +0 lines, -49 lines 0 comments Download
M site/user/quick/android.md View 1 2 3 4 5 4 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
djsollen
So this is a rather large change, but the bulk of the changes are just ...
5 years, 5 months ago (2015-07-08 18:36:07 UTC) #2
scroggo
lgtm https://codereview.chromium.org/1215023017/diff/20001/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/1215023017/diff/20001/site/user/quick/android.md#newcode168 site/user/quick/android.md:168: SampleApp on ARM and Intel devices. Why do ...
5 years, 5 months ago (2015-07-08 18:39:35 UTC) #3
djsollen
https://codereview.chromium.org/1215023017/diff/20001/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/1215023017/diff/20001/site/user/quick/android.md#newcode168 site/user/quick/android.md:168: SampleApp on ARM and Intel devices. On 2015/07/08 18:39:35, ...
5 years, 5 months ago (2015-07-08 18:49:47 UTC) #4
scroggo
On 2015/07/08 18:49:47, djsollen wrote: > https://codereview.chromium.org/1215023017/diff/20001/site/user/quick/android.md > File site/user/quick/android.md (right): > > https://codereview.chromium.org/1215023017/diff/20001/site/user/quick/android.md#newcode168 > ...
5 years, 5 months ago (2015-07-08 18:55:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215023017/20001
5 years, 5 months ago (2015-07-09 13:37:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/963)
5 years, 5 months ago (2015-07-09 13:39:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215023017/60001
5 years, 5 months ago (2015-07-22 18:01:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1260)
5 years, 5 months ago (2015-07-22 18:02:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215023017/80001
5 years, 5 months ago (2015-07-22 18:13:36 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/425535f1626932e4e22f61a2571f9c3c2b1c5977
5 years, 5 months ago (2015-07-22 18:33:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215023017/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1215023017/100001
5 years, 5 months ago (2015-07-24 20:07:28 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 20:16:03 UTC) #22
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/d18b861061253c8691949379546a7f96c9e251c9

Powered by Google App Engine
This is Rietveld 408576698