Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1215023010: Fix style propagation to continuations (Closed)

Created:
5 years, 5 months ago by Xianzhu
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix style propagation to continuations The original loop in updateStyleOfAnonymousBlockContinuations() is incorrect: it will propagate styles of the inline to sibling anonymous blocks not belonging to the continuation chain of this inline. Break the loop when we meet the end of the continuation chain. BUG=506669 TEST=fast/repaint/outline-continuations.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198543

Patch Set 1 #

Patch Set 2 : Fix bug #

Patch Set 3 : Fix bug again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -32 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/outline-continuations.html View 1 1 chunk +11 lines, -6 lines 0 comments Download
A LayoutTests/platform/linux/fast/repaint/outline-continuations-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/repaint/outline-continuations-expected.txt View 1 1 chunk +19 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 2 2 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Xianzhu
5 years, 5 months ago (2015-07-07 19:14:52 UTC) #2
Xianzhu
The patch has a bug. Will upload a new patch soon.
5 years, 5 months ago (2015-07-07 19:26:42 UTC) #3
Xianzhu
On 2015/07/07 19:26:42, Xianzhu wrote: > The patch has a bug. Will upload a new ...
5 years, 5 months ago (2015-07-07 19:47:31 UTC) #6
Xianzhu
On 2015/07/07 19:47:31, Xianzhu wrote: > On 2015/07/07 19:26:42, Xianzhu wrote: > > The patch ...
5 years, 5 months ago (2015-07-08 20:08:56 UTC) #7
Xianzhu
On 2015/07/08 20:08:56, Xianzhu wrote: > On 2015/07/07 19:47:31, Xianzhu wrote: > > On 2015/07/07 ...
5 years, 5 months ago (2015-07-08 22:39:40 UTC) #8
Xianzhu
On 2015/07/08 22:39:40, Xianzhu wrote: > On 2015/07/08 20:08:56, Xianzhu wrote: > > On 2015/07/07 ...
5 years, 5 months ago (2015-07-08 22:41:45 UTC) #9
leviw_travelin_and_unemployed
Good catch. LGTM.
5 years, 5 months ago (2015-07-08 22:43:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215023010/80001
5 years, 5 months ago (2015-07-08 23:02:47 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 23:06:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198543

Powered by Google App Engine
This is Rietveld 408576698