Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1215023003: Fix tests broken by default text color change. (Closed)

Created:
5 years, 5 months ago by iansf
Modified:
5 years, 5 months ago
Reviewers:
Hixie, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -145 lines) Patch
D sky/tests/clipping/background-opaque-clipped-gradients.sky View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/tests/clipping/background-opaque-clipped-gradients-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/tests/clipping/clipping-transforms.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/clipping/clipping-transforms-expected.sky View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/tests/harness/reftest-mismatch.sky View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/tests/harness/reftest-mismatch-expected-mismatch.sky View 1 chunk +5 lines, -0 lines 0 comments Download
D sky/tests/lowlevel/iframe.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/tests/lowlevel/iframe-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/tests/styles/media-queries.sky View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/tests/styles/media-queries-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
iansf
5 years, 5 months ago (2015-06-29 21:46:18 UTC) #1
Hixie
lgtm losing the iframe test is sad. Do we have a bug on bringing that ...
5 years, 5 months ago (2015-06-29 21:49:56 UTC) #2
abarth-chromium
lgtm
5 years, 5 months ago (2015-06-29 21:50:35 UTC) #4
iansf
5 years, 5 months ago (2015-06-29 21:58:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8499b13d071d7eb5dad9c5550ae37de4a289f96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698