Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1215023002: Fix theme changing: turns out we were not reparenting stateful surviving nodes when their parents c… (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix theme changing: turns out we were not reparenting stateful surviving nodes when their parents changed identity This also makes the optimistic/pessimistic mode switch change the active theme, because why not. While I was at it I also provided a debug boolean argument to runApp() to make it possible to profile more easily. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c728179f4e91480e219fed1a0a4553b5fe77a788

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -11 lines) Patch
M sky/sdk/example/stocks/lib/main.dart View 1 2 1 chunk +22 lines, -9 lines 0 comments Download
M sky/sdk/lib/painting/box_painter.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 1 2 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-06-29 20:45:45 UTC) #2
Hixie
5 years, 5 months ago (2015-06-29 20:56:22 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c728179f4e91480e219fed1a0a4553b5fe77a788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698