Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: components/tracing/child_trace_message_filter.cc

Issue 12150004: Category group support/Renamings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed comment, added better support for default filtering, fixed merge issues. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/child_trace_message_filter.cc
diff --git a/components/tracing/child_trace_message_filter.cc b/components/tracing/child_trace_message_filter.cc
index 1b001a7027966a0e8195decaa5ae03fb4c929d31..dea1a9a8cde7ea3643bb3b7d1ae123283426b11b 100644
--- a/components/tracing/child_trace_message_filter.cc
+++ b/components/tracing/child_trace_message_filter.cc
@@ -45,9 +45,7 @@ bool ChildTraceMessageFilter::OnMessageReceived(const IPC::Message& message) {
ChildTraceMessageFilter::~ChildTraceMessageFilter() {}
-void ChildTraceMessageFilter::OnBeginTracing(
- const std::vector<std::string>& included_categories,
- const std::vector<std::string>& excluded_categories,
+void ChildTraceMessageFilter::OnBeginTracing(std::string category_filter_str,
dsinclair 2013/03/12 21:27:24 const std::string&
rterrazas 2013/03/20 08:48:49 Done.
base::TimeTicks browser_time,
int options) {
#if defined(__native_client__)
@@ -59,8 +57,7 @@ void ChildTraceMessageFilter::OnBeginTracing(
TraceLog::GetInstance()->SetTimeOffset(time_offset);
#endif
TraceLog::GetInstance()->SetEnabled(
- included_categories,
- excluded_categories,
+ base::debug::CategoryFilter(category_filter_str),
static_cast<base::debug::TraceLog::Options>(options));
}
@@ -74,9 +71,9 @@ void ChildTraceMessageFilter::OnEndTracing() {
TraceLog::GetInstance()->Flush(
base::Bind(&ChildTraceMessageFilter::OnTraceDataCollected, this));
- std::vector<std::string> categories;
- TraceLog::GetInstance()->GetKnownCategories(&categories);
- channel_->Send(new TracingHostMsg_EndTracingAck(categories));
+ std::vector<std::string> category_groups;
+ TraceLog::GetInstance()->GetKnownCategoryGroups(&category_groups);
+ channel_->Send(new TracingHostMsg_EndTracingAck(category_groups));
}
void ChildTraceMessageFilter::OnGetTraceBufferPercentFull() {

Powered by Google App Engine
This is Rietveld 408576698