Issue 12150003: Remove extension scheme check in MediaStreamManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12150003: Remove extension scheme check in MediaStreamManager. (Closed)

Created:
7 years, 10 months ago by justinlin

Modified:
7 years, 10 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove extension scheme check in MediaStreamManager. This is not needed since the request will be verified in MediaStreamDevicesController::HandleTabMediaRequest. TEST=TabCaptireApiTest::TabCapturePermissionsTestFlagOff NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180370

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	content/browser/renderer_host/media/media_stream_manager.cc	View		2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/12150003/1

7 years, 10 months ago (2013-02-01 04:16:02 UTC) #4

justinlin

7 years, 10 months ago (2013-02-04 19:36:10 UTC) #5

On 2013/02/01 04:16:02, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/justinlin%40chromium.org/12150003/1

Reopening to reland once we figure out that this is not causing failures (also
hopefully CQ is fixed by then).

Expand Messages | Collapse Messages