- Invoke FinishDiscovery() if no network interfaces are detected.

chrome/browser/extensions/api/dial/dial_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DIAL_DIAL_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_API_DIAL_DIAL_SERVICE_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 84 matching lines @@
 
   // DialService implementation
   virtual bool Discover() OVERRIDE;
   virtual void AddObserver(Observer* observer) OVERRIDE;
   virtual void RemoveObserver(Observer* observer) OVERRIDE;
   virtual bool HasObserver(Observer* observer) OVERRIDE;
 
  private:
   virtual ~DialServiceImpl();
 
-  // Starts the flow to construct and send a discovery request.
-  void StartRequest();
+  // Starts the control flow for one discovery cycle.
+  void StartDiscovery();
 
-  // Establishes the UDP socket that is used for requests and responses, then
-  // sends a discovery request on the bound socket.  Returns |true| if
-  // successful.
-  bool BindAndWriteSocket(const net::NetworkInterface& bind_interface);
+  // Establishes the UDP socket that is used for requests and responses,
+  // establishes a read callback on the socket, and sends the first discovery
+  // request.  Returns true if successful.
+  bool BindSocketAndSendRequest(const net::IPAddressNumber& bind_ip_address);
+
+  // Sends a single discovery request over the socket.
+  void SendOneRequest();
 
   // Callback invoked for socket writes.
   void OnSocketWrite(int result);
 
   // Method to get the network list on the FILE thread.
   void DoGetNetworkList();
 
   // Send the network list to IO thread.
   void SendNetworkList(const net::NetworkInterfaceList& list);
 
@@ skipping 32 matching lines @@
 
   // The multicast address:port for search requests.
   net::IPEndPoint send_address_;
 
   // The NetLog for this service.
   net::NetLog* net_log_;
 
   // The NetLog source for this service.
   net::NetLog::Source net_log_source_;
 
+  // NOTE(mfoltz): It would make this class cleaner to refactor most of the

[justinlin, 2013/02/08 08:56:20]

Move this TODO to the top of this class or somewhere more relevant, maybe above
"StartDiscovery"?

[mark a. foltz, 2013/02/08 22:07:58]

Done, and elaborated it a bit.

+  // following state into its own |DiscoveryOperation| object that was managed
+  // by the DialServiceImpl object.
+
   // Buffer for socket writes.
   scoped_refptr<net::StringIOBuffer> send_buffer_;
 
   // Marks whether there is an active write callback.
   bool is_writing_;
 
   // Buffer for socket reads.
   scoped_refptr<net::IOBufferWithSize> recv_buffer_;
 
   // The source of of the last socket read.
   net::IPEndPoint recv_address_;
 
   // Marks whether there is an active read callback.
   bool is_reading_;
 
   // True when we are currently doing discovery.
   bool discovery_active_;
 
   // The number of requests that have been sent in the current discovery.
   int num_requests_sent_;
 
+  // The maximum number of requests to send per discovery cycle.
+  int max_requests_;
+
   // Timer for finishing discovery.
   base::OneShotTimer<DialServiceImpl> finish_timer_;
 
   // The delay for |finish_timer_|; how long to wait for discovery to finish.
+  // Setting this to zero disables the timer.
   base::TimeDelta finish_delay_;
 
+  // Timer for sending multiple requests at fixed intervals.
+  base::RepeatingTimer<DialServiceImpl> request_timer_;
+
+  // The delay for |request_timer_|; how long to wait between successive
+  // requests.
+  base::TimeDelta request_interval_;
+
   // List of observers.
   ObserverList<Observer> observer_list_;
 
   // Thread checker.
   base::ThreadChecker thread_checker_;
 
+  FRIEND_TEST_ALL_PREFIXES(DialServiceTest, TestSendMultipleRequests);
   FRIEND_TEST_ALL_PREFIXES(DialServiceTest, TestOnDeviceDiscovered);
   FRIEND_TEST_ALL_PREFIXES(DialServiceTest, TestOnDiscoveryFinished);
   FRIEND_TEST_ALL_PREFIXES(DialServiceTest, TestOnDiscoveryRequest);
   FRIEND_TEST_ALL_PREFIXES(DialServiceTest, TestResponseParsing);
   DISALLOW_COPY_AND_ASSIGN(DialServiceImpl);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DIAL_DIAL_SERVICE_H_