Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1214973003: Add cast_crash and cast_shell unittests to chromium.linux.json. (Closed)

Created:
5 years, 5 months ago by slan
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke, gunsch
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cast_crash and cast_shell unittests to chromium.linux.json. Also correct and update entries in ninja_to_gn.pyl. BUG= Committed: https://crrev.com/0f4b5381f94299714d92a23ff6b3953cb122dcf3 Cr-Commit-Position: refs/heads/master@{#336812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M testing/buildbot/chromium.linux.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/ninja_to_gn.pyl View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
slan
5 years, 5 months ago (2015-06-30 00:07:10 UTC) #2
gunsch
lgtm from chromecast perspective
5 years, 5 months ago (2015-06-30 00:13:18 UTC) #3
Dirk Pranke
lgtm, thanks!
5 years, 5 months ago (2015-06-30 16:35:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214973003/1
5 years, 5 months ago (2015-06-30 16:39:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 17:45:50 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 17:46:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f4b5381f94299714d92a23ff6b3953cb122dcf3
Cr-Commit-Position: refs/heads/master@{#336812}

Powered by Google App Engine
This is Rietveld 408576698