Oilpan: support observer retirement during lifetime notifications.

Source/core/frame/DOMWindowLifecycleNotifier.cpp

 /*
  * Copyright (C) 2013 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 16 matching lines @@
 #include "config.h"
 #include "core/frame/DOMWindowLifecycleNotifier.h"
 
 #include "core/frame/DOMWindowLifecycleObserver.h"
 
 namespace blink {
 
 void DOMWindowLifecycleNotifier::notifyAddEventListener(LocalDOMWindow* window, const AtomicString& eventType)
 {
     TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
+#if !ENABLE(OILPAN)
+    // Notifications perform unknown amounts of heap allocations,
+    // which might trigger (conservative) GCs. This will flush out
+    // dead observers, causing the _non-heap_ set be updated. Snapshot
+    // the observers and explicitly check if they're still alive before
+    // notifying.
+    Vector<RawPtr<DOMWindowLifecycleObserver>> snapshotOfObservers;
+    copyToVector(m_observers, snapshotOfObservers);
+    for (DOMWindowLifecycleObserver* observer : snapshotOfObservers) {
+        if (m_observers.contains(observer))
+            observer->didAddEventListener(window, eventType);
+    }
+#else
     for (DOMWindowLifecycleObserver* observer : m_observers)
         observer->didAddEventListener(window, eventType);
+#endif
 }
 
 void DOMWindowLifecycleNotifier::notifyRemoveEventListener(LocalDOMWindow* window, const AtomicString& eventType)
 {
     TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
+#if !ENABLE(OILPAN)
+    // Notifications perform unknown amounts of heap allocations,
+    // which might trigger (conservative) GCs. This will flush out
+    // dead observers, causing the _non-heap_ set be updated. Snapshot
+    // the observers and explicitly check if they're still alive before
+    // notifying.
+    Vector<RawPtr<DOMWindowLifecycleObserver>> snapshotOfObservers;
+    copyToVector(m_observers, snapshotOfObservers);
+    for (DOMWindowLifecycleObserver* observer : snapshotOfObservers) {
+        if (m_observers.contains(observer))
+            observer->didRemoveEventListener(window, eventType);
+    }
+#else
     for (DOMWindowLifecycleObserver* observer : m_observers)
         observer->didRemoveEventListener(window, eventType);
+#endif
 }
 
 void DOMWindowLifecycleNotifier::notifyRemoveAllEventListeners(LocalDOMWindow* window)
 {
     TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
+#if !ENABLE(OILPAN)
+    // Notifications perform unknown amounts of heap allocations,
+    // which might trigger (conservative) GCs. This will flush out
+    // dead observers, causing the _non-heap_ set be updated. Snapshot
+    // the observers and explicitly check if they're still alive before
+    // notifying.
+    Vector<RawPtr<DOMWindowLifecycleObserver>> snapshotOfObservers;
+    copyToVector(m_observers, snapshotOfObservers);
+    for (DOMWindowLifecycleObserver* observer : snapshotOfObservers) {
+        if (m_observers.contains(observer))
+            observer->didRemoveAllEventListeners(window);
+    }
+#else
     for (DOMWindowLifecycleObserver* observer : m_observers)
         observer->didRemoveAllEventListeners(window);
+#endif
 }
 
 } // namespace blink