Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1214953003: Debugger: allow recompiling toplevel code for debugging. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: allow recompiling toplevel code for debugging. R=mvstanton@chromium.org BUG=v8:4132 LOG=N Committed: https://crrev.com/d16c61bf62def6b9d9527f04e054c238b8791f3e Cr-Commit-Position: refs/heads/master@{#29370}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/debug.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 5 months ago (2015-06-30 07:46:17 UTC) #1
mvstanton
Looks good. LGTM.
5 years, 5 months ago (2015-06-30 09:12:56 UTC) #2
mvstanton
Looks good. LGTM.
5 years, 5 months ago (2015-06-30 09:12:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214953003/20001
5 years, 5 months ago (2015-06-30 09:17:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-30 09:43:45 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 09:44:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d16c61bf62def6b9d9527f04e054c238b8791f3e
Cr-Commit-Position: refs/heads/master@{#29370}

Powered by Google App Engine
This is Rietveld 408576698