Issue 1214943005: Rename scheduleFrame/setBeginFrameCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1214943005: Rename scheduleFrame/setBeginFrameCallback (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Rename scheduleFrame/setBeginFrameCallback These are now scheduleFrame/setFrameCallback. Also, update schduler.dart to not poke at sky.window, which is now always null. Fixes #178 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f5a4a183c0366023ea1ce698dff1ecaffbc2b583

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -54 lines)			Patch
M	sky/engine/core/core.gni	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	sky/engine/core/view/BeginFrameCallback.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	sky/engine/core/view/BeginFrameCallback.idl	View		1 chunk	+0 lines, -7 lines	0 comments	Download
A +	sky/engine/core/view/FrameCallback.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
A +	sky/engine/core/view/FrameCallback.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/view/View.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/view/View.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/engine/core/view/View.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/raw/painting.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/raw/shadow.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/raw/spinning_arabic.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/raw/spinning_image.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/raw/spinning_square.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/base/scheduler.dart	View		2 chunks	+1 line, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-06 16:57:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f5a4a183c0366023ea1ce698dff1ecaffbc2b583 (presubmit successful).