runtime/bin/BUILD.gn - Issue 1214933010: These missing dependencies will cause a violation of "gn check" in a future version of gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/BUILD.gn

Issue 1214933010: These missing dependencies will cause a violation of "gn check" in a future version of gn. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/BUILD.gn

diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn

index 2ee4114cbcd25f020340517306b4381de3d74233..bbc4d3e83fc57a3ee1266c448b305989dcf0f32f 100644

--- a/runtime/bin/BUILD.gn

+++ b/runtime/bin/BUILD.gn

@@ -143,8 +143,11 @@ static_library("libdart_nosnapshot") {

executable("gen_snapshot") {

configs += ["..:dart_config"]

deps = [

- ":libdart_nosnapshot",

+ ":generate_builtin_cc_file",

+ ":generate_io_cc_file",

+ ":generate_io_patch_cc_file",

":libdart_builtin",

+ ":libdart_nosnapshot",

]

sources = [

« no previous file with comments | « no previous file | no next file » | no next file with comments »