Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/source_file.cc

Issue 1214933007: Normalize paths in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually "git add" the test file. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/path_output_unittest.cc ('k') | tools/gn/source_file_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/source_file.cc
diff --git a/tools/gn/source_file.cc b/tools/gn/source_file.cc
index 820429552810497a6e9226265355eaada042f72e..41a602d2f01f0d8c293a5cadb05a329519b3bb33 100644
--- a/tools/gn/source_file.cc
+++ b/tools/gn/source_file.cc
@@ -30,12 +30,14 @@ SourceFile::SourceFile(const base::StringPiece& p)
: value_(p.data(), p.size()) {
DCHECK(!value_.empty());
AssertValueSourceFileString(value_);
+ NormalizePath(&value_);
}
SourceFile::SourceFile(SwapIn, std::string* value) {
value_.swap(*value);
DCHECK(!value_.empty());
AssertValueSourceFileString(value_);
+ NormalizePath(&value_);
}
SourceFile::~SourceFile() {
« no previous file with comments | « tools/gn/path_output_unittest.cc ('k') | tools/gn/source_file_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698