Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1214903017: Return this in Context::native_context if receiver is a native context. (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Return this in Context::native_context if receiver is a native context. Checking for native context is faster than checking for global object. Additionally it speeds up the case were it actually is the native context, while not slowing down the alternative case. The bootstrapper only needs to access the native context from the native context, so this avoids the expensive fallback. BUG= Committed: https://crrev.com/fdc5c1343cb5786fa0a21feefa34a472a64369f1 Cr-Commit-Position: refs/heads/master@{#29423}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M src/contexts.cc View 1 1 chunk +7 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-01 13:30:10 UTC) #2
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/1214903017/diff/1/src/contexts.cc File src/contexts.cc (right): https://codereview.chromium.org/1214903017/diff/1/src/contexts.cc#newcode89 src/contexts.cc:89: // Fast case: the global object ...
5 years, 5 months ago (2015-07-01 14:14:27 UTC) #3
Toon Verwaest
Updated comment
5 years, 5 months ago (2015-07-01 14:21:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214903017/20001
5 years, 5 months ago (2015-07-01 14:22:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-01 15:34:24 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 15:34:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdc5c1343cb5786fa0a21feefa34a472a64369f1
Cr-Commit-Position: refs/heads/master@{#29423}

Powered by Google App Engine
This is Rietveld 408576698