Remove chromeos==0 blacklist for test_isolation_mode.

Remove chromeos==0 blacklist for test_isolation_mode.

All of plain linux, chromeos work just fine and have been for a long time.

iOS and Android are also using .isolate files but in a different enough way that
it's not using test_isolation_mode==check, at least not yet.

TBR=smut@chromium.org
BUG=98637
Committed: https://crrev.com/cf15207e009794f74915d9b10d2e838b0d0c86f2
Cr-Commit-Position: refs/heads/master@{#337503}

[Marc-Antoine Ruel (Google), 2015-06-30 22:41:06]

maruel@google.com changed reviewers:
+ maruel@google.com

[M-A Ruel, 2015-07-03 19:21:43]

maruel@chromium.org changed reviewers:
- maruel@google.com

[smut, 2015-07-06 20:12:09]

smut@google.com changed reviewers:
+ smut@google.com

[smut, 2015-07-06 20:12:09]

This generates .isolate files for iOS tests? What will the command be?

[M-A Ruel, 2015-07-06 20:28:01]

On 2015/07/06 20:12:09, smut wrote:
> This generates .isolate files for iOS tests? What will the command be?

For the relevant targets as used via swarming, but can remove this and only
strip chromeos blacklist to stay on the safe side.

[smut, 2015-07-06 20:37:55]

On 2015/07/06 20:28:01, M-A Ruel wrote:
> On 2015/07/06 20:12:09, smut wrote:
> > This generates .isolate files for iOS tests? What will the command be?
> 
> For the relevant targets as used via swarming, but can remove this and only
> strip chromeos blacklist to stay on the safe side.

If "check" only means dependencies get verified and nothing else, then this is
fine.

[M-A Ruel, 2015-07-06 20:41:21]

On 2015/07/06 20:37:55, smut wrote:
> On 2015/07/06 20:28:01, M-A Ruel wrote:
> > On 2015/07/06 20:12:09, smut wrote:
> > > This generates .isolate files for iOS tests? What will the command be?
> > 
> > For the relevant targets as used via swarming, but can remove this and only
> > strip chromeos blacklist to stay on the safe side.
> 
> If "check" only means dependencies get verified and nothing else, then this is
> fine.

Yes, this is the default.

[M-A Ruel, 2015-07-06 20:56:24]

On 2015/07/06 20:41:21, M-A Ruel wrote:
> On 2015/07/06 20:37:55, smut wrote:
> > On 2015/07/06 20:28:01, M-A Ruel wrote:
> > > On 2015/07/06 20:12:09, smut wrote:
> > > > This generates .isolate files for iOS tests? What will the command be?
> > > 
> > > For the relevant targets as used via swarming, but can remove this and
only
> > > strip chromeos blacklist to stay on the safe side.
> > 
> > If "check" only means dependencies get verified and nothing else, then this
is
> > fine.
> 
> Yes, this is the default.

Looks like it broke ios. I'll revert the iOS part, there's no urgency.

[smut, 2015-07-06 21:00:34]

On 2015/07/06 20:56:24, M-A Ruel wrote:
> On 2015/07/06 20:41:21, M-A Ruel wrote:
> > On 2015/07/06 20:37:55, smut wrote:
> > > On 2015/07/06 20:28:01, M-A Ruel wrote:
> > > > On 2015/07/06 20:12:09, smut wrote:
> > > > > This generates .isolate files for iOS tests? What will the command be?
> > > > 
> > > > For the relevant targets as used via swarming, but can remove this and
> only
> > > > strip chromeos blacklist to stay on the safe side.
> > > 
> > > If "check" only means dependencies get verified and nothing else, then
this
> is
> > > fine.
> > 
> > Yes, this is the default.
> 
> Looks like it broke ios. I'll revert the iOS part, there's no urgency.

Should update CL description as well, "Remove chromeos==0 blacklist for
test_isolation_mode". Rs lgtm I guess, we'll see if CQ catches any similar
errors on ChromeOS.

[M-A Ruel, 2015-07-06 21:01:50]

updated CL description

[M-A Ruel, 2015-07-06 21:02:02]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-07-06 21:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214903013/20001

[commit-bot: I haz the power, 2015-07-06 21:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-06 21:02:53]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[M-A Ruel, 2015-07-06 21:24:10]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-07-06 21:24:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214903013/20001

[commit-bot: I haz the power, 2015-07-06 22:47:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-06 22:48:24]

Patchset 2 (id:??) landed as
https://crrev.com/cf15207e009794f74915d9b10d2e838b0d0c86f2
Cr-Commit-Position: refs/heads/master@{#337503}

[tapted, 2015-07-07 00:05:45]

Could this have caused
https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge...

(could also be a NaCL flake, or missing dependency in .gyp)

compile failure
https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge...

[6346/6381] RULE interactive_ui_tests_run:
isolate_66259a49d84685497c67f134062c657d interactive_ui_tests.isolate
/* snip */
FAILED: cd ../../chrome; python ../tools/isolate_driver.py check --isolated
"../out_x86-generic/Release/interactive_ui_tests.isolated" --isolate
"interactive_ui_tests.isolate" --path-variable DEPTH .. --path-variable
PRODUCT_DIR "../out_x86-generic/Release " --extra-variable
"version_full=45.0.2450.0" --config-variable "CONFIGURATION_NAME=Release"
--config-variable "OS=linux" --config-variable "asan=0" --config-variable
"branding=Chromium" --config-variable "chromeos=1" --config-variable
"component=static_library" --config-variable "disable_nacl=0" --config-variable
"enable_pepper_cdms=1" --config-variable "enable_plugins=1" --config-variable
"fastbuild=0" --config-variable "icu_use_data_file_flag=1" --config-variable
"internal_gles2_conform_tests=0" --config-variable "kasko=0" --config-variable
"libpeer_target_type=static_library" --config-variable "lsan=0"
--config-variable "msan=0" --config-variable "target_arch=ia32"
--config-variable "tsan=0" --config-variable "use_custom_libcxx=0"
--config-variable "use_instrumented_libraries=0" --config-variable
"use_prebuilt_instrumented_libraries=0" --config-variable "use_openssl=0"
--config-variable "use_ozone=0" --config-variable "use_x11=1" --config-variable
"v8_use_external_startup_data=1"
Failed to find an input file: Input file
/b/build/slave/ChromiumOS_x86-generic_Compile/build/src/out_x86-generic/Release/nacl_irt_x86_64.nexe
doesn't exist
ninja: build stopped: subcommand failed.

next build still cycling...

[tapted, 2015-07-07 00:27:46]

> next build still cycling...

repeated in the next cycle with the same error.

If you enable rietveld's "experimental trybot results", I also see the same
error on a tryjob at
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...

So I'm going to try reverting (sorry!)

[M-A Ruel, 2015-07-07 00:29:21]

On 2015/07/07 00:27:46, tapted wrote:
> > next build still cycling...
> 
> repeated in the next cycle with the same error.
> 
> If you enable rietveld's "experimental trybot results", I also see the same
> error on a tryjob at
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...
> 
> So I'm going to try reverting (sorry!)

Yes please revert. As to why nacl_irt_x86_64.nexe is not produced in this
configuration; I have no idea yet, will have to look eventually.

[tapted, 2015-07-07 00:30:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1227583002/ by tapted@chromium.org.

The reason for reverting is: fails 'compile on ChromiumOS x86-generic Compile,
Link:

https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge...

Error like
[6346/6381] RULE interactive_ui_tests_run:
isolate_66259a49d84685497c67f134062c657d interactive_ui_tests.isolate
/* snip */
FAILED: cd ../../chrome; python ../tools/isolate_driver.py check --isolated
"../out_x86-generic/Release/interactive_ui_tests.isolated" --isolate
"interactive_ui_tests.isolate" /* snip */
Failed to find an input file: Input file
/b/build/slave/ChromiumOS_x86-generic_Compile/build/src/out_x86-generic/Release/nacl_irt_x86_64.nexe
doesn't exist
.