Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2247)

Unified Diff: chrome/browser/extensions/webstore_data_fetcher.cc

Issue 1214903010: Make JSONParser a pure interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_data_fetcher.cc
diff --git a/chrome/browser/extensions/webstore_data_fetcher.cc b/chrome/browser/extensions/webstore_data_fetcher.cc
index c6e5a57074e0d6dbdcc4bb377a647fe111728a7f..1b082b90761a5ccdbf18dac072c4f9677e565bc6 100644
--- a/chrome/browser/extensions/webstore_data_fetcher.cc
+++ b/chrome/browser/extensions/webstore_data_fetcher.cc
@@ -82,13 +82,11 @@ void WebstoreDataFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
std::string webstore_json_data;
fetcher->GetResponseAsString(&webstore_json_data);
- scoped_refptr<safe_json::SafeJsonParser> parser =
- new safe_json::SafeJsonParser(
- webstore_json_data,
- base::Bind(&WebstoreDataFetcher::OnJsonParseSuccess, AsWeakPtr()),
- base::Bind(&WebstoreDataFetcher::OnJsonParseFailure, AsWeakPtr()));
// The parser will call us back via one of the callbacks.
- parser->Start();
+ safe_json::SafeJsonParser::Parse(
+ webstore_json_data,
+ base::Bind(&WebstoreDataFetcher::OnJsonParseSuccess, AsWeakPtr()),
+ base::Bind(&WebstoreDataFetcher::OnJsonParseFailure, AsWeakPtr()));
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698