Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1754)

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

Issue 1214903010: Make JSONParser a pure interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_data_fetcher.cc » ('j') | components/safe_json/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
index 0d06b3bb7b0461bb0fee27e61b24553f3642fc37..661bf478158998bc14dd8b2ba7db123a17d98944 100644
--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
@@ -184,18 +184,16 @@ void ChromeManagementAPIDelegate::
GetPermissionWarningsByManifestFunctionDelegate(
extensions::ManagementGetPermissionWarningsByManifestFunction* function,
const std::string& manifest_str) const {
- scoped_refptr<safe_json::SafeJsonParser> parser(
- new safe_json::SafeJsonParser(
- manifest_str,
- base::Bind(
- &extensions::ManagementGetPermissionWarningsByManifestFunction::
- OnParseSuccess,
- function),
- base::Bind(
- &extensions::ManagementGetPermissionWarningsByManifestFunction::
- OnParseFailure,
- function)));
- parser->Start();
+ safe_json::SafeJsonParser::Parse(
+ manifest_str,
+ base::Bind(
+ &extensions::ManagementGetPermissionWarningsByManifestFunction::
+ OnParseSuccess,
+ function),
+ base::Bind(
+ &extensions::ManagementGetPermissionWarningsByManifestFunction::
+ OnParseFailure,
+ function));
}
scoped_ptr<extensions::InstallPromptDelegate>
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_data_fetcher.cc » ('j') | components/safe_json/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698