Make JSONParser a pure interface.

components/safe_json/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # GYP version: components/safe_json.gypi:safe_json
 static_library("safe_json") {

[brettw, 2015/07/07 22:17:21]

This static library should be a source set. Static libraries should basically
never be used in GN unless you want a .a for some specific reason (it's slower).

   sources = [
     "safe_json_parser.cc",
     "safe_json_parser.h",
+    "safe_json_parser_impl.cc",
+    "safe_json_parser_impl.h",
   ]
 
   defines = [ "SAFE_JSON_IMPLEMENTATION" ]

[brettw, 2015/07/07 22:17:21]

This does nothing and should be removed. GYP also. This is only for if you're
doing components and have a _export.h file that reads this define.

 
   deps = [
     ":safe_json_parser_message_filter",
     "//base",
     "//components/strings",
     "//content/public/browser",
     "//ui/base",
   ]
 }
 
+# GYP version: components/safe_json.gypi:safe_json_test_support
+source_set("test_support") {
+  testonly = true
+  sources = [
+    "testing_json_parser.cc",
+    "testing_json_parser.h",
+  ]
+
+  deps = [
+    ":safe_json",
+    "//base",
+  ]
+}
+
+# GYP version: components/safe_json.gypi:safe_json_parser_message_filter
 static_library("safe_json_parser_message_filter") {

[brettw, 2015/07/07 22:17:21]

source_set

   sources = [
     "safe_json_parser_message_filter.cc",
     "safe_json_parser_message_filter.h",
     "safe_json_parser_messages.cc",
     "safe_json_parser_messages.h",
   ]
 
   deps = [
     "//base",
     "//content/public/browser",
     "//ipc",
   ]
 }