Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1214903009: PPC: Fix constant pool overflow access in Get/SetRelocatedValue. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix constant pool overflow access in Get/SetRelocatedValue. This resolves the mirror-object test failure. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/fc6cc7c1e0a9596c75ded6d60bb3e809cbfd86dd Cr-Commit-Position: refs/heads/master@{#29391}

Patch Set 1 #

Patch Set 2 : New function for duplicate code. #

Patch Set 3 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M src/ppc/macro-assembler-ppc.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 2 3 chunks +31 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
5 years, 5 months ago (2015-06-30 16:13:26 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-06-30 17:14:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214903009/40001
5 years, 5 months ago (2015-06-30 17:39:04 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-06-30 18:57:18 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 18:57:32 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc6cc7c1e0a9596c75ded6d60bb3e809cbfd86dd
Cr-Commit-Position: refs/heads/master@{#29391}

Powered by Google App Engine
This is Rietveld 408576698