Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1214903007: X87: [turbofan] Add basic support for calling to (a subset of) C functions. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add basic support for calling to (a subset of) C functions. port a58ba8d80179bf5b6b7245590c82e47fda8c8a5e (r29279). original commit message: This introduces some initial building blocks for calling out to C/C++ functions directly from TurboFan generated code objects. BUG= Committed: https://crrev.com/4ed8444e73838e244bb04bd52ecd7cb450cf577d Cr-Commit-Position: refs/heads/master@{#29408}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -13 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +35 lines, -13 lines 0 comments Download
M src/compiler/x87/linkage-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-06-30 09:17:21 UTC) #3
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 11:01:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214903007/20001
5 years, 5 months ago (2015-07-01 11:01:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-01 11:31:53 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 11:32:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ed8444e73838e244bb04bd52ecd7cb450cf577d
Cr-Commit-Position: refs/heads/master@{#29408}

Powered by Google App Engine
This is Rietveld 408576698