Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12149004: [cc] Show GPU memory usage and overage below FPS counter (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Show GPU memory usage and overage below FPS counter R=enne BUG=173301 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180246

Patch Set 1 #

Patch Set 2 : changing approach to graph, wip #

Patch Set 3 : works #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -6 lines) Patch
M cc/cc.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/heads_up_display_layer_impl.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 2 3 5 chunks +51 lines, -1 line 0 comments Download
M cc/layer_tree_host_impl.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M cc/layer_tree_impl.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layer_tree_impl.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A cc/memory_history.h View 1 1 chunk +54 lines, -0 lines 0 comments Download
A cc/memory_history.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M cc/ring_buffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tile_manager.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M cc/tile_manager.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nduca
7 years, 10 months ago (2013-02-01 06:10:40 UTC) #1
enne (OOO)
lgtm
7 years, 10 months ago (2013-02-01 06:13:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12149004/1
7 years, 10 months ago (2013-02-01 06:51:12 UTC) #3
enne (OOO)
lgtm, with some nits https://codereview.chromium.org/12149004/diff/16001/cc/heads_up_display_layer_impl.cc File cc/heads_up_display_layer_impl.cc (right): https://codereview.chromium.org/12149004/diff/16001/cc/heads_up_display_layer_impl.cc#newcode318 cc/heads_up_display_layer_impl.cc:318: needless extra line https://codereview.chromium.org/12149004/diff/16001/cc/heads_up_display_layer_impl.cc#newcode419 cc/heads_up_display_layer_impl.cc:419: ...
7 years, 10 months ago (2013-02-01 17:17:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12149004/9002
7 years, 10 months ago (2013-02-01 20:55:29 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-01 21:44:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12149004/23001
7 years, 10 months ago (2013-02-02 00:06:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106768
7 years, 10 months ago (2013-02-02 04:32:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12149004/23001
7 years, 10 months ago (2013-02-02 04:51:32 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-02 06:00:35 UTC) #10
Message was sent while issue was closed. 
Change committed as 180246

Powered by Google App Engine
This is Rietveld 408576698