Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 1214893004: X87: change the float max/min operation. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: change the float max/min operation when operands. This CL fixes the following situations: 1, Operands are -0.0 or 0.0. it always return right value. 1, Operands contains NaN. it always return right value. BUG= Committed: https://crrev.com/68020ce5467d2ced9484659d1afdb59a7a9e3741 Cr-Commit-Position: refs/heads/master@{#29407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -37 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 6 chunks +8 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-06-30 09:15:35 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 11:01:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214893004/1
5 years, 5 months ago (2015-07-01 11:01:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 11:29:04 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 11:29:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68020ce5467d2ced9484659d1afdb59a7a9e3741
Cr-Commit-Position: refs/heads/master@{#29407}

Powered by Google App Engine
This is Rietveld 408576698