content/browser/renderer_host/media/audio_renderer_host.h - Issue 1214883004: Fixed the audio backgrounding bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.h

Issue 1214883004: Fixed the audio backgrounding bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed gab's comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/media/audio_renderer_host.h

diff --git a/content/browser/renderer_host/media/audio_renderer_host.h b/content/browser/renderer_host/media/audio_renderer_host.h

index ed89e93dd2165314d45bfcfd35f73066df356157..006cca34dabf7d14395ef3d06bba0994c84f9a33 100644

--- a/content/browser/renderer_host/media/audio_renderer_host.h

+++ b/content/browser/renderer_host/media/audio_renderer_host.h

@@ -216,7 +216,8 @@ class CONTENT_EXPORT AudioRendererHost : public BrowserMessageFilter {

// A map of stream IDs to audio sources.

AudioEntryMap audio_entries_;

- // The number of streams in the playing state.

+ // The number of streams in the playing state. Atomic read safe from any

+ // thread, but should only be updated from the IO thread.

base::AtomicRefCount num_playing_streams_;

// Salt required to translate renderer device IDs to raw device IDs