Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 1214883004: Fixed the audio backgrounding bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and fixed the tests for macosx Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index e6c2f8252948449b90a0b1f7d43e5a91eae238f9..d5f8e63f100731da0aa2b7b73b4688e57228379d 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -112,6 +112,7 @@ class CONTENT_EXPORT RenderProcessHostImpl
void WidgetRestored() override;
void WidgetHidden() override;
int VisibleWidgetCount() const override;
+ void AudioStateChanged() override;
bool IsForGuestsOnly() const override;
StoragePartition* GetStoragePartition() const override;
bool Shutdown(int exit_code, bool wait) override;
@@ -323,8 +324,10 @@ class CONTENT_EXPORT RenderProcessHostImpl
const base::CommandLine& browser_cmd,
base::CommandLine* renderer_cmd) const;
- // Callers can reduce the RenderProcess' priority.
- void SetBackgrounded(bool backgrounded);
+ // Inspects the current object state and sets/removes background priority if
+ // appropriate. Should be called after any of the involved data members
+ // change.
+ void UpdateProcessPriority();
// Handle termination of our process.
void ProcessDied(bool already_dead, RendererClosedDetails* known_details);
@@ -355,8 +358,9 @@ class CONTENT_EXPORT RenderProcessHostImpl
// backgrounded.
int32 visible_widgets_;
- // Does this process have backgrounded priority.
- bool backgrounded_;
+ // Whether this process currently has backgrounded priority. Tracked so that
gab 2015/08/07 19:55:06 s/has backgrounded priority/is backgrounded/
+ // UpdateProcessPriority() can avoid redundantly setting the priority.
gab 2015/08/07 19:55:06 Don't document "why" it's tracked, just state what
+ bool is_process_backgrounded_;
// Used to allow a RenderWidgetHost to intercept various messages on the
// IO thread.

Powered by Google App Engine
This is Rietveld 408576698