Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 1214883004: Fixed the audio backgrounding bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implemented nick's suggestion Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc
index dddeee21626a31f30aff5b4f749c396fcd5024b8..ce25de2c4e86091ad1dbd982b9889721217b1204 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host.cc
@@ -61,6 +61,16 @@ void NotifyResourceDispatcherOfAudioStateChange(int render_process_id,
render_process_id, render_view_id, is_playing);
}
+void NotifyRenderProcessHostThatAudioStateChanged(int render_process_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+ RenderProcessHost* render_process_host =
+ RenderProcessHost::FromID(render_process_id);
+
+ if (render_process_host)
+ render_process_host->AudioStateChanged();
+}
+
} // namespace
class AudioRendererHost::AudioEntry
@@ -651,11 +661,26 @@ void AudioRendererHost::UpdateNumPlayingStreams(AudioEntry* entry,
!RenderFrameHasActiveAudio(entry->render_frame_id());
entry->set_playing(true);
base::AtomicRefCountInc(&num_playing_streams_);
+
+ // Inform the renderer host when audio starts playing for the first time.
gab 2015/08/04 19:40:24 s/renderer host/RenderProcessHost/
sebsg 2015/08/06 21:11:47 Done.
+ if (base::AtomicRefCountIsOne(&num_playing_streams_)) {
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&NotifyRenderProcessHostThatAudioStateChanged,
+ render_process_id_));
+ }
} else {
entry->set_playing(false);
should_alert_resource_scheduler =
!RenderFrameHasActiveAudio(entry->render_frame_id());
- base::AtomicRefCountDec(&num_playing_streams_);
+
+ // Inform the renderer when there is no more audio playing.
gab 2015/08/04 19:40:24 s/renderer/RenderProcessHost/
sebsg 2015/08/06 21:11:47 Done.
+ if (!base::AtomicRefCountDec(&num_playing_streams_)) {
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&NotifyRenderProcessHostThatAudioStateChanged,
+ render_process_id_));
+ }
}
if (should_alert_resource_scheduler && ResourceDispatcherHostImpl::Get()) {

Powered by Google App Engine
This is Rietveld 408576698