Fixed the audio backgrounding bug

content/browser/renderer_host/render_process_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_
 
 #include <map>
 #include <queue>
 #include <string>
@@ skipping 10 matching lines @@
 #include "ipc/ipc_channel_proxy.h"
 #include "ipc/ipc_platform_file.h"
 #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h"
 #include "ui/gfx/gpu_memory_buffer.h"
 #include "ui/gl/gpu_switching_observer.h"
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 #include "content/common/mac/io_surface_manager_token.h"
 #endif
 
+#if defined(OS_MACOSX)
+#include "content/browser/mach_broker_mac.h"
+#endif
+
 namespace base {
 class CommandLine;
 class MessageLoop;
 }
 
 namespace gfx {
 class Size;
 }
 
 namespace gpu {
@@ skipping 64 matching lines @@
   bool Init() override;
   int GetNextRoutingID() override;
   void AddRoute(int32 routing_id, IPC::Listener* listener) override;
   void RemoveRoute(int32 routing_id) override;
   void AddObserver(RenderProcessHostObserver* observer) override;
   void RemoveObserver(RenderProcessHostObserver* observer) override;
   void ShutdownForBadMessage() override;
   void WidgetRestored() override;
   void WidgetHidden() override;
   int VisibleWidgetCount() const override;
+  void AudioStateChanged() override;
   bool IsForGuestsOnly() const override;
   StoragePartition* GetStoragePartition() const override;
   bool Shutdown(int exit_code, bool wait) override;
   bool FastShutdownIfPossible() override;
   base::ProcessHandle GetHandle() const override;
   BrowserContext* GetBrowserContext() const override;
   bool InSameStoragePartition(StoragePartition* partition) const override;
   int GetID() const override;
   bool HasConnection() const override;
   void SetIgnoreInputEvents(bool ignore_input_events) override;
@@ skipping 26 matching lines @@
   const base::TimeTicks& GetInitTimeForNavigationMetrics() const override;
   bool SubscribeUniformEnabled() const override;
   void OnAddSubscription(unsigned int target) override;
   void OnRemoveSubscription(unsigned int target) override;
   void SendUpdateValueState(
       unsigned int target, const gpu::ValueState& state) override;
 #if defined(ENABLE_BROWSER_CDMS)
   media::BrowserCdm* GetBrowserCdm(int render_frame_id,
                                    int cdm_id) const override;
 #endif
+#if defined(OS_MACOSX)
+  mach_port_t GetMachTaskPortForTesting() const override;

[gab, 2015/08/24 20:59:22]

Only need #include <mach/mach.h> for |mach_port_t| I think.

e.g., ref:
https://code.google.com/p/chromium/codesearch#chromium/src/base/mac/scoped_ma...

If so, mach_broker_mac.h can go in .cc :-)

[Robert Sesek, 2015/08/24 21:44:48]

Correct. And there's already an #if for OS_MACOSX on line 27, so use that block.

[sebsg, 2015/08/25 01:35:59]

In fact, I don't think I need to include mach/mach.h :)

[sebsg, 2015/08/25 01:35:59]

Acknowledged.

+#endif
 
   // IPC::Sender via RenderProcessHost.
   bool Send(IPC::Message* msg) override;
 
   // IPC::Listener via RenderProcessHost.
   bool OnMessageReceived(const IPC::Message& msg) override;
   void OnChannelConnected(int32 peer_pid) override;
   void OnChannelError() override;
   void OnBadMessageReceived(const IPC::Message& message) override;
 
@@ skipping 145 matching lines @@
   // results to |*command_line|.
   void AppendRendererCommandLine(base::CommandLine* command_line) const;
 
   // Copies applicable command line switches from the given |browser_cmd| line
   // flags to the output |renderer_cmd| line flags. Not all switches will be
   // copied over.
   void PropagateBrowserCommandLineToRenderer(
       const base::CommandLine& browser_cmd,
       base::CommandLine* renderer_cmd) const;
 
-  // Callers can reduce the RenderProcess' priority.
-  void SetBackgrounded(bool backgrounded);
+  // Inspects the current object state and sets/removes background priority if
+  // appropriate. Should be called after any of the involved data members
+  // change.
+  void UpdateProcessPriority();
 
   // Handle termination of our process.
   void ProcessDied(bool already_dead, RendererClosedDetails* known_details);
 
   // GpuSwitchingObserver implementation.
   void OnGpuSwitched() override;
 
 #if defined(ENABLE_WEBRTC)
   void OnRegisterAecDumpConsumer(int id);
   void OnUnregisterAecDumpConsumer(int id);
@@ skipping 10 matching lines @@
 
   // The registered IPC listener objects. When this list is empty, we should
   // delete ourselves.
   IDMap<IPC::Listener> listeners_;
 
   // The count of currently visible widgets.  Since the host can be a container
   // for multiple widgets, it uses this count to determine when it should be
   // backgrounded.
   int32 visible_widgets_;
 
-  // Does this process have backgrounded priority.
-  bool backgrounded_;
+  // Whether this process currently has backgrounded priority. Tracked so that
+  // UpdateProcessPriority() can avoid redundantly setting the priority.
+  bool is_process_backgrounded_;
 
   // Used to allow a RenderWidgetHost to intercept various messages on the
   // IO thread.
   scoped_refptr<RenderWidgetHelper> widget_helper_;
 
   // The filter for GPU-related messages coming from the renderer.
   // Thread safety note: this field is to be accessed from the UI thread.
   // We don't keep a reference to it, to avoid it being destroyed on the UI
   // thread, but we clear this field when we clear channel_. When channel_ goes
   // away, it posts a task to the IO thread to destroy it there, so we know that
@@ skipping 128 matching lines @@
 #endif
 
   base::WeakPtrFactory<RenderProcessHostImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderProcessHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_