Issue 1214863019: Followup to previous MIPS commit: implement dump(), rebase more.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1214863019: Followup to previous MIPS commit: implement dump(), rebase more. (Closed)

Created:
5 years, 5 months ago by jvoung (off chromium)

Modified:
5 years, 5 months ago

Reviewers:
Karl, Jim Stichnoth, John, reed.kotler

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Followup to previous MIPS commit: implement dump(), rebase more. When compiling with DEBUG, there is a problem linking InstMIPS32. It overrides dump, but never defined that. Also, update the code for some recent changes. Namely, we no longer check ALLOW_DUMP but instead check BuildDefs::dump(). Also, the instruction dtors have been deleted. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4167 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3469b02435b919623e628881b449fe8f11615b88

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	src/IceInstMIPS32.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	src/IceInstMIPS32.cpp	View		3 chunks	+16 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

5 years, 5 months ago (2015-07-09 17:32:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3469b02435b919623e628881b449fe8f11615b88 (presubmit successful).