Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: Source/core/inspector/ScriptDebuggerBase.h

Issue 1214863013: [DevTools] Remove ScriptDebugListener from V8Debugger. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/MainThreadDebugger.cpp ('k') | Source/core/inspector/ScriptDebuggerBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/ScriptDebuggerBase.h
diff --git a/Source/core/inspector/ScriptDebuggerBase.h b/Source/core/inspector/ScriptDebuggerBase.h
index f50671e8099e60a6a4ba3fc257895a74bd947cc9..0654ca2ae78e0ffcee31fbb140669693f8f06628 100644
--- a/Source/core/inspector/ScriptDebuggerBase.h
+++ b/Source/core/inspector/ScriptDebuggerBase.h
@@ -11,16 +11,28 @@
namespace blink {
+class ScriptDebugListener;
+
class CORE_EXPORT ScriptDebuggerBase : public V8Debugger::Client {
WTF_MAKE_NONCOPYABLE(ScriptDebuggerBase);
public:
- ScriptDebuggerBase(v8::Isolate*, PassOwnPtrWillBeRawPtr<V8Debugger>);
+ explicit ScriptDebuggerBase(v8::Isolate*);
~ScriptDebuggerBase() override;
- v8::Local<v8::Object> compileDebuggerScript() override;
V8Debugger* debugger() const { return m_debugger.get(); }
+ v8::Local<v8::Object> compileDebuggerScript() override;
+ void didParseSource(v8::Local<v8::Context>, const V8Debugger::ParsedScript&) override;
+ V8Debugger::SkipPauseRequest didPause(ScriptState*, const ScriptValue& callFrames, const ScriptValue& exception, const Vector<String>& hitBreakpoints, bool isPromiseRejection) override;
+ bool v8AsyncTaskEventsEnabled(ScriptState*) override;
+ void didReceiveV8AsyncTaskEvent(ScriptState*, const String& eventType, const String& eventName, int id) override;
+ bool v8PromiseEventsEnabled(ScriptState*) override;
+ void didReceiveV8PromiseEvent(ScriptState*, v8::Local<v8::Object> promise, v8::Local<v8::Value> parentPromise, int status) override;
+
DECLARE_VIRTUAL_TRACE();
+protected:
+ virtual ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) = 0;
+
private:
v8::Isolate* m_isolate;
OwnPtrWillBeMember<V8Debugger> m_debugger;
« no previous file with comments | « Source/core/inspector/MainThreadDebugger.cpp ('k') | Source/core/inspector/ScriptDebuggerBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698