Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1214853028: One more fix for making removing overlays incremental changes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index e520eb507dde92315b986207ee43ad5e8109dbec..5195922606590e6def6983f3da90232190958f3f 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -2191,13 +2191,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
// contents is the same as it was in the overlay.
try {
TimestampedData<String> fileContents = getContents(source);
- String fileContentsData = fileContents.data;
- if (fileContentsData == originalContents) {
- sourceEntry.setValue(SourceEntry.CONTENT, fileContentsData);
- sourceEntry.modificationTime = fileContents.modificationTime;
+ newContents = fileContents.data;
+ sourceEntry.modificationTime = fileContents.modificationTime;
+ if (newContents == originalContents) {
+ sourceEntry.setValue(SourceEntry.CONTENT, newContents);
changed = false;
}
- newContents = fileContentsData;
} catch (e) {}
// If not the same content (e.g. the file is being closed without save),
// then force analysis.
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698