Issue 1214843005: [es6] disable optimization in lazily parsed arrows with rest params

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1214843005: [es6] disable optimization in lazily parsed arrows with rest params (Closed)

Created:
5 years, 5 months ago by caitp (gmail)

Modified:
5 years, 5 months ago

Reviewers:
wingo, rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[es6] disable optimization in lazily parsed arrows with rest params BUG=508074 LOG=N R=rossberg@chromium.org, wingo@igalia.com

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/parser.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

caitp (gmail)

Here's a quick go at it, it passes the test and reproduction locally

5 years, 5 months ago (2015-07-08 13:54:21 UTC) #1

caitp (gmail)

On 2015/07/08 13:54:21, caitp wrote: > Here's a quick go at it, it passes the ...

5 years, 5 months ago (2015-07-08 13:54:51 UTC) #2

caitp (gmail)

On 2015/07/08 15:26:52, rossberg wrote: > I suppose this is obsoleted by unshipping? I can ...

5 years, 5 months ago (2015-07-08 15:36:41 UTC) #4

rossberg

5 years, 5 months ago (2015-07-08 15:44:08 UTC) #5

On 2015/07/08 15:36:41, caitp wrote:
> I can try to fix the non-lazy path this week, which would allow re-shipping
> 
> Another option is figuring out how to get the crankshaft code working, and yet
> another option is re-implementing rest params with desugaring.

No shipping in 45, it's too late, either way. And if we ship later anyway, then
maybe it makes more sense to do the reimplementation?

Expand Messages | Collapse Messages