Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1214803004: Fix cluster-fuzz found regression in d8 Workers. (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix cluster-fuzz found regression in d8 Workers. This one occurs when Function.prototype.toString is overridden to return a non-string. BUG=chromium:504729 R=mstarzinger@chromium.org LOG=n Committed: https://crrev.com/e291b78a8ef4f5898052c58cdd3e85e430d86202 Cr-Commit-Position: refs/heads/master@{#29351}

Patch Set 1 #

Patch Set 2 : assertThrows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/d8.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-504729.js View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
5 years, 5 months ago (2015-06-26 23:39:53 UTC) #1
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-06-29 09:36:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214803004/20001
5 years, 5 months ago (2015-06-29 15:20:04 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-29 15:53:14 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 15:53:30 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e291b78a8ef4f5898052c58cdd3e85e430d86202
Cr-Commit-Position: refs/heads/master@{#29351}

Powered by Google App Engine
This is Rietveld 408576698