Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.h

Issue 1214793002: Fix a memory leak in the app banner prompt layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase again Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/app_banner/BeforeInstallPromptEvent.h
diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.h b/Source/modules/app_banner/BeforeInstallPromptEvent.h
index c5fd15324ee23665d52d795555b05280cd3a8757..7c6ff6427e9a8472a6cf8ad30cb5640b32928bdb 100644
--- a/Source/modules/app_banner/BeforeInstallPromptEvent.h
+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.h
@@ -6,6 +6,7 @@
#define BeforeInstallPromptEvent_h
#include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/ScriptPromiseResolver.h"
#include "modules/EventModules.h"
#include "platform/heap/Handle.h"
@@ -48,7 +49,7 @@ private:
BeforeInstallPromptEvent(const AtomicString& name, const BeforeInstallPromptEventInit&);
Vector<String> m_platforms;
- ScriptPromise m_userChoice;
+ RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;
int m_requestId;
WebAppBannerClient* m_client;
« no previous file with comments | « LayoutTests/app_banner/app-banner-event-prompt.html ('k') | Source/modules/app_banner/BeforeInstallPromptEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698