Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: Source/modules/serviceworkers/WindowClient.idl

Issue 1214733006: Service Worker: Correct WindowClient.idl (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/WindowClient.idl
diff --git a/Source/modules/serviceworkers/WindowClient.idl b/Source/modules/serviceworkers/WindowClient.idl
index 40a5ddcd783c940bdc2839a2ab0d393396fb3c70..3af859b12a83640eac243b5cd89dabe784ccf3f2 100644
--- a/Source/modules/serviceworkers/WindowClient.idl
+++ b/Source/modules/serviceworkers/WindowClient.idl
@@ -20,6 +20,5 @@ enum ContextFrameType {
] interface WindowClient : Client {
readonly attribute VisibilityState visibilityState;
readonly attribute boolean focused;
- readonly attribute ContextFrameType frameType;
zino 2015/07/03 02:38:57 Clarify: This is already defined in Client and we
- [CallWith=ScriptState] Promise<boolean> focus();
+ [CallWith=ScriptState] Promise<WindowClient> focus();
nhiroki 2015/07/03 03:18:08 A promise resolution value type is just an annotat
falken 2015/07/03 03:22:49 Doesn't the C++ code need updating too? I assume w
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698