Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1214733006: Service Worker: Correct WindowClient.idl (Closed)

Created:
5 years, 5 months ago by jungkees
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Correct WindowClient.idl - Remove WindowClient.frameType attribute . This is already defined in Client and we don't need to redefine. This change doesn't affect any behavior. - Change the promise resolution value type of WindowClient.focus() from boolean to WindowClient. . A promise resolution value type is just an annotation in WebIDL, so this change does not affect actual implementation. We already resolve with WindowClient, see http/tests/serviceworker/chromium/windowclient-focus.html. Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#window-client-interface BUG=506736 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198269

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase; Update webexposed interface expected list. #

Patch Set 3 : Don't trim trailing white space in the original file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/WindowClient.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 26 (10 generated)
jungkees
PTAL
5 years, 5 months ago (2015-07-03 02:29:50 UTC) #2
zino
Looks good to me. I think it is better to add the spec link to ...
5 years, 5 months ago (2015-07-03 02:38:57 UTC) #3
jungkees
Thanks for review, zino@. I added the spec link in the CL description. OWNERS, PTAL
5 years, 5 months ago (2015-07-03 02:45:25 UTC) #5
nhiroki
https://codereview.chromium.org/1214733006/diff/1/Source/modules/serviceworkers/WindowClient.idl File Source/modules/serviceworkers/WindowClient.idl (right): https://codereview.chromium.org/1214733006/diff/1/Source/modules/serviceworkers/WindowClient.idl#newcode23 Source/modules/serviceworkers/WindowClient.idl:23: [CallWith=ScriptState] Promise<WindowClient> focus(); A promise resolution value type is ...
5 years, 5 months ago (2015-07-03 03:18:08 UTC) #6
falken
+mlamouri who implemented focus() https://codereview.chromium.org/1214733006/diff/1/Source/modules/serviceworkers/WindowClient.idl File Source/modules/serviceworkers/WindowClient.idl (right): https://codereview.chromium.org/1214733006/diff/1/Source/modules/serviceworkers/WindowClient.idl#newcode23 Source/modules/serviceworkers/WindowClient.idl:23: [CallWith=ScriptState] Promise<WindowClient> focus(); Doesn't the ...
5 years, 5 months ago (2015-07-03 03:22:49 UTC) #8
falken
On 2015/07/03 03:18:08, nhiroki wrote: > https://codereview.chromium.org/1214733006/diff/1/Source/modules/serviceworkers/WindowClient.idl > File Source/modules/serviceworkers/WindowClient.idl (right): > > https://codereview.chromium.org/1214733006/diff/1/Source/modules/serviceworkers/WindowClient.idl#newcode23 > ...
5 years, 5 months ago (2015-07-03 03:23:38 UTC) #9
nhiroki
On 2015/07/03 03:23:38, falken wrote: > On 2015/07/03 03:18:08, nhiroki wrote: > > > https://codereview.chromium.org/1214733006/diff/1/Source/modules/serviceworkers/WindowClient.idl ...
5 years, 5 months ago (2015-07-03 03:31:01 UTC) #10
falken
OK thanks for the links. jungkee: Can you edit the CL description to be clear ...
5 years, 5 months ago (2015-07-03 03:38:19 UTC) #11
jungkees
Yes I had double-checked the test is running okay. Thanks all for the review and ...
5 years, 5 months ago (2015-07-03 04:02:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214733006/1
5 years, 5 months ago (2015-07-03 04:03:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/69167) (exceeded global retry quota)
5 years, 5 months ago (2015-07-03 05:09:54 UTC) #16
jungkees
Rebased onto ToT and updated global-interface-listing-service-worker-expected.txt.
5 years, 5 months ago (2015-07-03 05:37:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214733006/20001
5 years, 5 months ago (2015-07-03 05:37:18 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/69630)
5 years, 5 months ago (2015-07-03 07:05:18 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214733006/40001
5 years, 5 months ago (2015-07-03 07:31:22 UTC) #25
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 08:24:21 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198269

Powered by Google App Engine
This is Rietveld 408576698