runtime/vm/exceptions.cc - Issue 1214723009: Make List constructor give better error messages for non-int arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.cc

Issue 1214723009: Make List constructor give better error messages for non-int arguments (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix test to also pass on dart2js. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/exceptions.cc

diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc

index fa2e44179de9d83d7c11aceb4fa1899363a25afb..2ab0f4daf495f643a2b7a2bbbbbdda4d664c147d 100644

--- a/runtime/vm/exceptions.cc

+++ b/runtime/vm/exceptions.cc

@@ -598,6 +598,11 @@ RawObject* Exceptions::Create(ExceptionType type, const Array& arguments) {

library = Library::CoreLibrary();

class_name = &Symbols::ArgumentError();

break;

+ case kArgumentValue:

+ library = Library::CoreLibrary();

+ class_name = &Symbols::ArgumentError();

+ constructor_name = &Symbols::DotValue();

+ break;

case kNoSuchMethod:

library = Library::CoreLibrary();

class_name = &Symbols::NoSuchMethodError();

« no previous file with comments | « runtime/vm/exceptions.h ('k') | runtime/vm/symbols.h » ('j') | sdk/lib/_internal/js_runtime/lib/js_array.dart » ('J')