Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214703002: Fix nanobench to reset gl/gr context after every config run. (Closed)

Created:
5 years, 5 months ago by egdaniel
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix nanobench to reset gl/gr context after every config run. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3bf9206ada256277a39988c263f0379d544fc27b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -42 lines) Patch
M bench/nanobench.cpp View 1 2 7 chunks +37 lines, -42 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
egdaniel
Change to nanobench to make sure we are resetting the context between every config run ...
5 years, 5 months ago (2015-06-26 14:05:25 UTC) #2
bsalomon
lgtm
5 years, 5 months ago (2015-06-26 14:17:46 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214703002/20001
5 years, 5 months ago (2015-06-26 14:23:43 UTC) #5
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-06-26 14:24:14 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214703002/20002
5 years, 5 months ago (2015-06-26 15:02:39 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-26 15:08:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214703002/20002
5 years, 5 months ago (2015-06-26 15:09:25 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-06-26 15:12:49 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:20002) as
https://skia.googlesource.com/skia/+/3bf9206ada256277a39988c263f0379d544fc27b

Powered by Google App Engine
This is Rietveld 408576698