Disable/enable echo for enterprise device.

chrome/browser/policy/policy_browsertest.cc

Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index b455aacdb744a3900df031421414f102ee9391d9..bbd43e2c9e7c9f561d3e89f9f058dc7a68098d56 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -102,7 +102,8 @@
 #include "webkit/plugins/npapi/plugin_utils.h"
 #include "webkit/plugins/plugin_constants.h"
 #include "webkit/plugins/webplugininfo.h"
-
+#include "chrome/browser/extensions/extension_apitest.h"
+#include "chrome/browser/extensions/component_loader.h"

[oscarpan, 2013/02/06 04:38:45]

Either remove or reorder the imports in future, as this version is not
finalized.

 #if defined(OS_CHROMEOS)
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accelerators/accelerator_table.h"
@@ -297,6 +298,21 @@ bool IsWebGLEnabled(content::WebContents* contents) {
   return result;
 }
 
+#if defined(OS_CHROMEOS)
+// Checks if redeeming cros offers is allowed in the given WebContents.
+bool CheckAllowRedeemCrosOffers(content::WebContents* contents) {
+  bool result = false;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      contents,
+      "chrome.echoPrivate.allowRedeemOffers("
+      "  function(allow) {"
+      "    domAutomationController.send(allow);"
+      "  });",
+      &result));
+  return result;
+}
+#endif
+
 bool IsJavascriptEnabled(content::WebContents* contents) {
   scoped_ptr<base::Value> value = content::ExecuteScriptAndGetValue(
       contents->GetRenderViewHost(), "123");
@@ -525,6 +541,20 @@ class PolicyTest : public InProcessBrowserTest {
     return details.ptr();
   }
 
+  const extensions::Extension* LoadExtensionAsComponent(
+      const FilePath& path) {
+    ExtensionService* service = extension_service();
+
+    std::string manifest;
+    if (!file_util::ReadFileToString(
+            path.Append(extensions::Extension::kManifestFilename),
+            &manifest))
+      return NULL;
+
+    std::string extension_id = service->component_loader()->Add(manifest, path);
+    return service->extensions()->GetByID(extension_id);
+  }
+

[oscarpan, 2013/02/06 04:38:45]

This seems a bit ugly. I'm trying to load my extension as a component extension.
This cannot be done by InstallExtension()

[Mattias Nissler (ping if slow), 2013/02/06 10:03:26]

That's fine. The alternative would be to add the test to echo_private_apitest.cc
and use RunComponentExtensionTest, but then you'll have to find a way to inject
policy into the extension testing framework - I'm not familiar enough with that
to know whether that's easily possible.

   void UninstallExtension(const std::string& id, bool expect_success) {
     content::WindowedNotificationObserver observer(
         expect_success ? chrome::NOTIFICATION_EXTENSION_UNINSTALLED
@@ -1314,6 +1344,41 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, IncognitoEnabled) {
   EXPECT_TRUE(BrowserList::IsOffTheRecordSessionActive());
 }
 
+#if defined(OS_CHROMEOS)
+IN_PROC_BROWSER_TEST_F(PolicyTest, AllowRedeemChromeOsRegistrationOffers) {
+  FilePath extension_path(ui_test_utils::GetTestFilePath(
+        FilePath(kTestExtensionsDir), FilePath("echo_component_extension")));
+  LoadExtensionAsComponent(extension_path);
+  content::WebContents* contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  contents->GetController().LoadURL(
+      GURL("chrome-extension://lbgjohhgghbkcgejgklgcmfijhbheflf/main.html"),
+      content::Referrer(),

[oscarpan, 2013/02/06 04:38:45]

Although it seems it can access chrome.echoPrivate api now, but i'm getting the
following error when running the test.

[17747:17747:0205/202052:ERROR:request_sender.cc(133)] Could not find specified
request id: 0
../../chrome/browser/policy/policy_browsertest.cc:1368: Failure
Value of: CheckAllowRedeemCrosOffers(contents)
  Actual: true
Expected: false
[17747:17747:0205/202052:ERROR:request_sender.cc(133)] Could not find specified
request id: 1
[17747:17747:0205/202052:ERROR:request_sender.cc(133)] Could not find specified
request id: 2
[  FAILED  ] PolicyTest.AllowRedeemChromeOsRegistrationOffers, where TypeParam =
 and GetParam() =  (3579 ms)
[----------] 1 test from PolicyTest (3580 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3580 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PolicyTest.AllowRedeemChromeOsRegistrationOffers, where TypeParam =
 and GetParam() = 

 1 FAILED TEST
[0205/202054:ERROR:process_util_posix.cc(297)] Unable to terminate process group
17702: No such process

[Mattias Nissler (ping if slow), 2013/02/06 10:03:26]

Seems like you want to attach a debugger and check why the policy value is not
taking effect in the extension function.

+      content::PAGE_TRANSITION_AUTO_TOPLEVEL,
+      std::string());
+  content::WaitForLoadStop(contents);
+  EXPECT_TRUE(CheckAllowRedeemCrosOffers(contents));
+  PolicyMap policies;
+
+  // Allow offer redemption and verify the flag value through js.
+  policies.Set(key::kDeviceAllowRedeemChromeOsRegistrationOffers,
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_MACHINE,
+               base::Value::CreateBooleanValue(false));
+  UpdateProviderPolicy(policies);
+  EXPECT_FALSE(CheckAllowRedeemCrosOffers(contents));
+
+  // Disallow offer redemption and verify the flag value through js.
+  policies.Set(key::kDeviceAllowRedeemChromeOsRegistrationOffers,
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_MACHINE,
+               base::Value::CreateBooleanValue(true));
+
+  UpdateProviderPolicy(policies);
+  EXPECT_TRUE(CheckAllowRedeemCrosOffers(contents));
+}
+#endif
+
 IN_PROC_BROWSER_TEST_F(PolicyTest, Javascript) {
   // Verifies that Javascript can be disabled.
   content::WebContents* contents =