Disable/enable echo for enterprise device.

chrome/browser/policy/policy_browsertest.cc

Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index b455aacdb744a3900df031421414f102ee9391d9..468e9c42f5ee0b3057424d1126ec5b98ab9ccd39 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -297,6 +297,21 @@ bool IsWebGLEnabled(content::WebContents* contents) {
   return result;
 }
 
+#if defined(OS_CHROMEOS)
+// Checks if redeeming cros offers is allowed in the given WebContents.
+bool CheckAllowRedeemCrosOffers(content::WebContents* contents) {
+  bool result = false;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      contents,
+      "chrome.echoPrivate.allowRedeemOffers("
+      "  function(allow) {"
+      "    domAutomationController.send(allow);"
+      "  });",
+      &result));
+  return result;
+}

[oscarpan, 2013/02/05 05:39:22]

Apparently my test failed. It complained "Cannot call method 'allowRedeemOffers'
of undefined". Because echoPrivate.allowRedeemOffers is a private api and can
only run in extension (instead of web page). I don't know how to test the new
policy in this case... Should I not use javascript at all?

[Mattias Nissler (ping if slow), 2013/02/05 13:06:53]

Have you made sure the extension is actually loaded for browser_tests? You may
have to do that manually. Another thing to try would be to have the tab navigate
to a URL that's within that extension's origin.

Also, aren't there browser tests for the echo private API already? If they
exist, they probably tell you what you need to do (or you can add your test case
there).

[oscarpan, 2013/02/06 04:34:54]

There are some tricky parts. First our extension is a component extension, which
supposed to be loaded automatically (not certain, someone told me). I indeed
tried to install our extension again (including adding a new crx file to the
test data dir), but still I'm having the same issue. Even I installed the
extension, I cannot navigate to it (but I can on the chrome on my linux
desktop). For our echo extension, we do have an extension browser test at
https://code.google.com/p/chromium/codesearch#chrome/src/chrome/browser/chrom...,
But that's parallel to policy browser tests. I was trying to copy some of the
codes from policy_browsertest.cc to echo_private_apitest.cc but that seems to
involve too much work, and I've not yet suceeded. I'm thinking if we revisit
this test case in a latter cl, so that we are not blocked on it. I'm very
welcome to work on within this cl if there are some obvious solution that i'm
not realize. What do you think? 


On 2013/02/05 13:06:53, Mattias Nissler wrote:

+#endif
+
 bool IsJavascriptEnabled(content::WebContents* contents) {
   scoped_ptr<base::Value> value = content::ExecuteScriptAndGetValue(
       contents->GetRenderViewHost(), "123");
@@ -1314,6 +1329,29 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, IncognitoEnabled) {
   EXPECT_TRUE(BrowserList::IsOffTheRecordSessionActive());
 }
 
+IN_PROC_BROWSER_TEST_F(PolicyTest, AllowRedeemChromeOsRegistrationOffers) {
+  content::WebContents* contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  EXPECT_TRUE(CheckAllowRedeemCrosOffers(contents));
+
+  PolicyMap policies;
+  policies.Set(key::kDeviceAllowRedeemChromeOsRegistrationOffers,
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_MACHINE,
+               base::Value::CreateBooleanValue(false));
+
+  UpdateProviderPolicy(policies);
+  EXPECT_FALSE(CheckAllowRedeemCrosOffers(contents));
+
+  policies.Set(key::kDeviceAllowRedeemChromeOsRegistrationOffers,
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_MACHINE,
+               base::Value::CreateBooleanValue(true));
+
+  UpdateProviderPolicy(policies);
+  EXPECT_TRUE(CheckAllowRedeemCrosOffers(contents));
+}
+
 IN_PROC_BROWSER_TEST_F(PolicyTest, Javascript) {
   // Verifies that Javascript can be disabled.
   content::WebContents* contents =