Disable/enable echo for enterprise device.

chrome/browser/policy/policy_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/string16.h"
 #include "base/stringprintf.h"
 #include "base/test/test_file_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/api/infobars/infobar_service.h"
 #include "chrome/browser/autocomplete/autocomplete_controller.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/download/download_prefs.h"
+#include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
 #include "chrome/browser/media/media_stream_devices_controller.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/mock_configuration_policy_provider.h"
 #include "chrome/browser/policy/policy_map.h"
@@ skipping 55 matching lines @@
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_filter.h"
 #include "policy/policy_constants.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "webkit/plugins/npapi/plugin_utils.h"
 #include "webkit/plugins/plugin_constants.h"
 #include "webkit/plugins/webplugininfo.h"
-
 #if defined(OS_CHROMEOS)
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accelerators/accelerator_table.h"
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "chrome/browser/chromeos/audio/audio_handler.h"
 #endif
 
 using content::BrowserThread;
 using content::URLRequestMockHTTPJob;
@@ skipping 174 matching lines @@
   bool result = false;
   EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
       contents,
       "var canvas = document.createElement('canvas');"
       "var context = canvas.getContext('experimental-webgl');"
       "domAutomationController.send(context != null);",
       &result));
   return result;
 }
 
+#if defined(OS_CHROMEOS)
+// Checks if redeeming cros offers is allowed in the given WebContents.
+bool CheckAllowRedeemCrosOffers(content::WebContents* contents) {
+  bool result = false;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      contents,
+      "chrome.echoPrivate.allowRedeemOffers("
+      "  function(allow) {"
+      "    domAutomationController.send(allow);"
+      "  });",
+      &result));
+  return result;
+}
+#endif
+
 bool IsJavascriptEnabled(content::WebContents* contents) {
   scoped_ptr<base::Value> value = content::ExecuteScriptAndGetValue(
       contents->GetRenderViewHost(), "123");
   int result = 0;
   if (!value->GetAsInteger(&result))
     EXPECT_EQ(base::Value::TYPE_NULL, value->GetType());
   return result == 123;
 }
 
 void CopyPluginListAndQuit(std::vector<webkit::WebPluginInfo>* out,
@@ skipping 208 matching lines @@
 
     content::WindowedNotificationObserver observer(
         chrome::NOTIFICATION_CRX_INSTALLER_DONE,
         content::NotificationService::AllSources());
     installer->InstallCrx(extension_path);
     observer.Wait();
     content::Details<const extensions::Extension> details = observer.details();
     return details.ptr();
   }
 
+  const extensions::Extension* LoadExtensionAsComponent(
+      const FilePath& path) {
+    ExtensionService* service = extension_service();
+
+    std::string manifest;
+    if (!file_util::ReadFileToString(
+            path.Append(extensions::Extension::kManifestFilename),
+            &manifest))
+      return NULL;
+
+    std::string extension_id = service->component_loader()->Add(manifest, path);
+    return service->extensions()->GetByID(extension_id);
+  }
+
   void UninstallExtension(const std::string& id, bool expect_success) {
     content::WindowedNotificationObserver observer(
         expect_success ? chrome::NOTIFICATION_EXTENSION_UNINSTALLED
                        : chrome::NOTIFICATION_EXTENSION_UNINSTALL_NOT_ALLOWED,
         content::NotificationService::AllSources());
     extension_service()->UninstallExtension(id, false, NULL);
     observer.Wait();
   }
 
   void UpdateProviderPolicy(const PolicyMap& policy) {
@@ skipping 769 matching lines @@
 
   // Enable via policy and verify that incognito windows can be opened.
   policies.Set(key::kIncognitoEnabled, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true));
   UpdateProviderPolicy(policies);
   EXPECT_TRUE(chrome::ExecuteCommand(browser(), IDC_NEW_INCOGNITO_WINDOW));
   EXPECT_EQ(2u, BrowserList::size());
   EXPECT_TRUE(BrowserList::IsOffTheRecordSessionActive());
 }
 
+#if defined(OS_CHROMEOS)
+IN_PROC_BROWSER_TEST_F(PolicyTest, AllowRedeemChromeOsRegistrationOffers) {
+  FilePath extension_path(ui_test_utils::GetTestFilePath(
+        FilePath(kTestExtensionsDir), FilePath("echo_component_extension")));
+  LoadExtensionAsComponent(extension_path);
+  content::WebContents* contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  contents->GetController().LoadURL(
+      GURL("chrome-extension://lbgjohhgghbkcgejgklgcmfijhbheflf/main.html"),
+      content::Referrer(),
+      content::PAGE_TRANSITION_AUTO_TOPLEVEL,
+      std::string());
+  content::WaitForLoadStop(contents);
+  EXPECT_TRUE(CheckAllowRedeemCrosOffers(contents));
+  PolicyMap policies;
+
+  // Allow offer redemption and verify the flag value through js.
+  policies.Set(key::kDeviceAllowRedeemChromeOsRegistrationOffers,
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_MACHINE,
+               base::Value::CreateBooleanValue(false));
+  UpdateProviderPolicy(policies);

[oscarpan, 2013/02/07 00:40:39]

So I confirmed that all other codes are running as expected. The only issue is
UpdateProviderPolicy will never update my policy.
To update the device policy,
SetInPolicy(https://code.google.com/p/chromium/codesearch#chrome/src/chrome/browser/chromeos/settings/device_settings_provider.cc&sq=package:chrome&type=cs&rcl=1360158437&l=697)
 has to be triggered, but the condition {if (trusted_status_ == TRUSTED &&
!pending_changes_.empty())} is never satisfied, because the flow always goes
here (case DeviceSettingsService::STORE_KEY_UNAVAILABLE:) 
https://code.google.com/p/chromium/codesearch#chrome/src/chrome/browser/chrom....

I think the reason is our policy is device policy and it is not handled properly
in this policy_browsertest.cc. So do you think we could postpone adding this
test given that the complexity is beyond the goal of this cl?

[Mattias Nissler (ping if slow), 2013/02/07 10:45:57]

Ah, that makes sense!
Sounds fair to me.

+  EXPECT_FALSE(CheckAllowRedeemCrosOffers(contents));
+
+  // Disallow offer redemption and verify the flag value through js.
+  policies.Set(key::kDeviceAllowRedeemChromeOsRegistrationOffers,
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_MACHINE,
+               base::Value::CreateBooleanValue(true));
+  UpdateProviderPolicy(policies);
+  EXPECT_TRUE(CheckAllowRedeemCrosOffers(contents));
+}
+#endif
+
 IN_PROC_BROWSER_TEST_F(PolicyTest, Javascript) {
   // Verifies that Javascript can be disabled.
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(IsJavascriptEnabled(contents));
   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_DEV_TOOLS));
   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_DEV_TOOLS_CONSOLE));
 
   // Disable Javascript via policy.
   PolicyMap policies;
@@ skipping 545 matching lines @@
                  this));
 
   MessageLoop::current()->Run();
 }
 
 INSTANTIATE_TEST_CASE_P(MediaStreamDevicesControllerBrowserTestInstance,
                         MediaStreamDevicesControllerBrowserTest,
                         testing::Bool());
 
 }  // namespace policy