Disable/enable echo for enterprise device.

chrome/browser/chromeos/extensions/echo_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/echo_private_api.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/location.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h"
+#include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/system/statistics_provider.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserThread;
 
 namespace {
 
 // For a given registration code type, returns the code value from the
 // underlying system. Caller owns the returned pointer.
 base::Value* GetValueForRegistrationCodeType(std::string& type) {
   // Possible ECHO code type and corresponding key name in StatisticsProvider.
   const std::string kCouponType = "COUPON_CODE";
   const std::string kCouponCodeKey = "ubind_attribute";
   const std::string kGroupType = "GROUP_CODE";
   const std::string kGroupCodeKey = "gbind_attribute";
 
   chromeos::system::StatisticsProvider* provider =
       chromeos::system::StatisticsProvider::GetInstance();
   std::string result;
   if (!chromeos::KioskModeSettings::Get()->IsKioskModeEnabled()) {

[Mattias Nissler (ping if slow), 2013/02/05 13:06:53]

Reminder: Introduce a check here as well.

[oscarpan, 2013/02/06 04:34:54]

Added a TODO, we'd like to get this cl in first, so let's revisit this check in
later cl!

[Mattias Nissler (ping if slow), 2013/02/06 10:03:26]

Why? Checking whether the policy is on or off is the same code as below. The
concern I have is that people can still call getRegistrationCode(), even if the
allowRedeemOffers returns false. What's your plan to prevent this? I'm not a fan
of committing half-finished known-broken code, in particular if the fix is as
simple as adding a check that you already have.

     // In Kiosk mode, we effectively disable the registration API
     // by always returning an empty code.
     if (type == kCouponType)
       provider->GetMachineStatistic(kCouponCodeKey, &result);
     else if (type == kGroupType)
       provider->GetMachineStatistic(kGroupCodeKey, &result);
   }
   return new base::StringValue(result);
 }
 
@@ skipping 43 matching lines @@
     base::Time::Exploded ctime;
     fileInfo.creation_time.UTCExplode(&ctime);
     timestamp += base::StringPrintf("%u-%u-%u",
                                     ctime.year,
                                     ctime.month,
                                     ctime.day_of_month);
   }
   SetResult(new base::StringValue(timestamp));
   return true;
 }
+
+AllowRedeemOffersFunction::AllowRedeemOffersFunction() {
+}
+
+AllowRedeemOffersFunction::~AllowRedeemOffersFunction() {
+}
+
+// Check the enterprise policy kAllowRedeemChromeOsRegistrationOffers flag
+// value. This policy is used to controll whether user can redeem offers using
+// enterprise device.
+bool AllowRedeemOffersFunction::RunImpl() {
+  bool allow = true;
+  // If the policy is not provided, "allow" will not be modified by
+  // GetBoolean.
+  // TODO(oscarpan): Check if we need to use PreparedTrustedValues.

[Mattias Nissler (ping if slow), 2013/02/05 13:06:53]

You should be using this. As pointed out by Xiyuan, it's not that hard - I don't
see why to postpone that bit.

[oscarpan, 2013/02/06 04:34:54]

Done.

+  chromeos::CrosSettings::Get()->GetBoolean(
+      chromeos::kAllowRedeemChromeOsRegistrationOffers, &allow);
+  SetResult(new base::FundamentalValue(allow));
+  return true;
+}