Introduce some util code for drawing vector assets.

ui/views/controls/throbber.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/throbber.h"
 
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/animation/tween.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/paint_throbber.h"
+#include "ui/gfx/vector_icons.h"
 #include "ui/native_theme/common_theme.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/views/resources/grit/views_resources.h"
 
 namespace views {
 
-Throbber::Throbber() : checked_(false), checkmark_(nullptr) {
+Throbber::Throbber() : checked_(false) {
 }
 
 Throbber::~Throbber() {
   Stop();
 }
 
 void Throbber::Start() {
   if (IsRunning())
     return;
 
@@ skipping 19 matching lines @@
   checked_ = checked;
   SchedulePaint();
 }
 
 gfx::Size Throbber::GetPreferredSize() const {
   const int kDefaultDiameter = 16;
   return gfx::Size(kDefaultDiameter, kDefaultDiameter);
 }
 
 void Throbber::OnPaint(gfx::Canvas* canvas) {
+  SkColor color = GetNativeTheme()->GetSystemColor(
+      ui::NativeTheme::kColorId_ThrobberSpinningColor);
+
   if (!IsRunning()) {
     if (checked_) {
-      if (!checkmark_) {
-        checkmark_ = ui::ResourceBundle::GetSharedInstance()
-                         .GetImageNamed(IDR_CHECKMARK)
-                         .ToImageSkia();
-      }
-
-      int checkmark_x = (width() - checkmark_->width()) / 2;
-      int checkmark_y = (height() - checkmark_->height()) / 2;
-      canvas->DrawImageInt(*checkmark_, checkmark_x, checkmark_y);
+      const int kDipSize = 18;

[Peter Kasting, 2015/07/01 22:26:58]

Hardcoding this makes me sad... is there any way to compute it from e.g. the
throbber's preferred size, or share this constant with other places, or
something?

[Evan Stade, 2015/07/02 00:08:06]

Yea, it's tricky. 18 is the magic dp for which the actual circle (less padding)
is 16dp. That is implicit in the drawing instructions, so not sure how to share.
I can move these constants to the same place and add a note to reduce the
probability of this breaking.

+      canvas->Translate(gfx::Vector2d((width() - kDipSize) / 2,
+                                      (height() - kDipSize) / 2));
+      gfx::PaintVectorIcon(canvas, gfx::VectorIconId::CHECK_CIRCLE, kDipSize,
+                           color);
     }
     return;
   }
 
-  SkColor color = GetNativeTheme()->GetSystemColor(
-      ui::NativeTheme::kColorId_ThrobberSpinningColor);
   base::TimeDelta elapsed_time = base::TimeTicks::Now() - start_time_;
   gfx::PaintThrobberSpinning(canvas, GetContentsBounds(), color, elapsed_time);
 }
 
 bool Throbber::IsRunning() const {
   return timer_.IsRunning();
 }
 
 // Smoothed throbber ---------------------------------------------------------
 
@@ skipping 31 matching lines @@
   stop_timer_.Start(FROM_HERE,
                     base::TimeDelta::FromMilliseconds(stop_delay_ms_), this,
                     &SmoothedThrobber::StopDelayOver);
 }
 
 void SmoothedThrobber::StopDelayOver() {
   Throbber::Stop();
 }
 
 }  // namespace views