src/IceTargetLowering.h - Issue 1214693004: ARM lowering integer divide and remainder, with div by 0 checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLowering.h

Issue 1214693004: ARM lowering integer divide and remainder, with div by 0 checks. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: review fixes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLowering.h

diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h

index 205e57341429c939e08bd3efa048d8de4152a7eb..b543208d2da5d227db4bd8e3fe3964379fe7d54c 100644

--- a/src/IceTargetLowering.h

+++ b/src/IceTargetLowering.h

@@ -353,16 +353,20 @@ protected:

const static constexpr char *H_fptoui_f64_i64 = "__Sz_fptoui_f64_i64";

const static constexpr char *H_frem_f32 = "fmodf";

const static constexpr char *H_frem_f64 = "fmod";

+ const static constexpr char *H_sdiv_i32 = "__divsi3";

const static constexpr char *H_sdiv_i64 = "__divdi3";

const static constexpr char *H_sitofp_i64_f32 = "__Sz_sitofp_i64_f32";

const static constexpr char *H_sitofp_i64_f64 = "__Sz_sitofp_i64_f64";

+ const static constexpr char *H_srem_i32 = "__modsi3";

const static constexpr char *H_srem_i64 = "__moddi3";

+ const static constexpr char *H_udiv_i32 = "__udivsi3";

const static constexpr char *H_udiv_i64 = "__udivdi3";

const static constexpr char *H_uitofp_4xi32_4xf32 = "__Sz_uitofp_4xi32_4xf32";

const static constexpr char *H_uitofp_i32_f32 = "__Sz_uitofp_i32_f32";

const static constexpr char *H_uitofp_i32_f64 = "__Sz_uitofp_i32_f64";

const static constexpr char *H_uitofp_i64_f32 = "__Sz_uitofp_i64_f32";

const static constexpr char *H_uitofp_i64_f64 = "__Sz_uitofp_i64_f64";

+ const static constexpr char *H_urem_i32 = "__umodsi3";

const static constexpr char *H_urem_i64 = "__umoddi3";

private:

« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/IceTargetLoweringARM32.h » ('j') | no next file with comments »