Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1214673004: Add tandrii and vadimsh as *.isolate owners. (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tandrii and vadimsh as *.isolate owners. Remove csharp since he's not working on test isolation anymore. R=vadimsh@chromium.org,tandrii@chromium.org TBR= BUG= NOTRY=true Committed: https://crrev.com/bc08d477da9c4ec24c7cbc93a72e1fde58f6738b Cr-Commit-Position: refs/heads/master@{#336399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M base/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M breakpad/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M cc/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M components/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M content/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M media/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M net/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M ui/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
M-A Ruel
Using TBR so I don't have to poke 10 different persons.
5 years, 6 months ago (2015-06-26 15:15:31 UTC) #1
tandrii(chromium)
lgtm
5 years, 6 months ago (2015-06-26 15:19:05 UTC) #2
Vadim Sh.
lgtm
5 years, 6 months ago (2015-06-26 17:15:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214673004/1
5 years, 6 months ago (2015-06-26 17:36:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 17:45:58 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc08d477da9c4ec24c7cbc93a72e1fde58f6738b Cr-Commit-Position: refs/heads/master@{#336399}
5 years, 6 months ago (2015-06-26 17:46:48 UTC) #7
Nico
If you TBR changes like this, you should get at least one owners lgtm I ...
4 years, 8 months ago (2016-03-30 12:40:04 UTC) #9
M-A Ruel
On 2016/03/30 12:40:04, Nico wrote: > If you TBR changes like this, you should get ...
4 years, 8 months ago (2016-03-30 14:17:51 UTC) #10
Nico
4 years, 8 months ago (2016-03-30 14:41:13 UTC) #11
Message was sent while issue was closed.
I don't think this change is wrong, just that tbring changes to owners
without any review is.
On Mar 30, 2016 10:17 AM, <maruel@chromium.org> wrote:

> On 2016/03/30 12:40:04, Nico wrote:
> > If you TBR changes like this, you should get at least one owners lgtm I
> think.
>
> The isolate files a largely busy work, and hopefully will get deleted by
> EOY,
> probably sooner. Then we can all get removed from these OWNERS files.
>
> https://codereview.chromium.org/1214673004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698