Issue 1214633009: Include mojo/public/cpp/bindings/binding.h wherever mojo::Binding<> is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1214633009: Include mojo/public/cpp/bindings/binding.h wherever mojo::Binding<> is used. (Closed)

Created:
5 years, 5 months ago by viettrungluu

Modified:
5 years, 5 months ago

Reviewers:
rudominer

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Include mojo/public/cpp/bindings/binding.h wherever mojo::Binding<> is used. Currently, these places are picking it up via some include chain involving interface_impl.h, which is bad since I'm going to delete that file (since InterfaceImpl<> is deprecated and no longer used) -- I'll do this separately. R=rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b54211faffb49507a3b382ccc1f2820cff44b8f7

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -0 lines)			Patch
M	apps/moterm/gl_helper.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/bitmap_uploader/bitmap_uploader.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/ganesh_app/texture_uploader.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/edk/js/tests/js_to_cpp_tests.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/gles2/command_buffer_client_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/gpu/texture_cache.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/cpp/application/lib/service_registry.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/binding_callback_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/request_response_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/validation_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/tests/task_tracker_perftest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	shell/child_main.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/viewer/compositor/surface_holder.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/viewer/internals.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 5 months ago (2015-07-07 20:57:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b54211faffb49507a3b382ccc1f2820cff44b8f7 (presubmit successful).

Expand Messages | Collapse Messages