Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1214633008: SkyDemo should launch demos in their own windows (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M sky/sdk/example/demo_launcher/apk/AndroidManifest.xml View 1 chunk +6 lines, -1 line 0 comments Download
M sky/sdk/example/demo_launcher/lib/main.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M sky/sdk/lib/mojo/activity.dart View 1 chunk +18 lines, -4 lines 0 comments Download
M sky/services/intents/intents.mojom View 1 chunk +1 line, -0 lines 1 comment Download
M sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-07 20:32:49 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1214633008/diff/1/sky/services/intents/intents.mojom File sky/services/intents/intents.mojom (right): https://codereview.chromium.org/1214633008/diff/1/sky/services/intents/intents.mojom#newcode20 sky/services/intents/intents.mojom:20: int32 flags; uint?
5 years, 5 months ago (2015-07-07 20:34:23 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-07 20:35:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f3a16eb04c3897386f4375961f7bfbb4b248cad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698