Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214633005: Remove CSS clients of ImageResource (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove CSS clients of ImageResource This CL is part of a series to remove the network dependency from Sky Engine. This CL removes the clients of ImageResource in sky/engine/core/css. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0da6086b70ddc6b1a42da267532350f17fbd2d6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1661 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/DeferredLegacyStyleInterpolation.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/DeferredLegacyStyleInterpolation.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
D sky/engine/core/animation/animatable/AnimatableImage.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/core/animation/animatable/AnimatableImage.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
M sky/engine/core/animation/animatable/AnimatableValueTestHelper.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/animatable/AnimatableValueTestHelper.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/core.gni View 4 chunks +0 lines, -12 lines 0 comments Download
D sky/engine/core/css/CSSCrossfadeValue.h View 1 chunk +0 lines, -109 lines 0 comments Download
D sky/engine/core/css/CSSCrossfadeValue.cpp View 1 chunk +0 lines, -211 lines 0 comments Download
M sky/engine/core/css/CSSImageGeneratorValue.cpp View 7 chunks +0 lines, -14 lines 0 comments Download
D sky/engine/core/css/CSSImageSetValue.h View 1 chunk +0 lines, -90 lines 0 comments Download
D sky/engine/core/css/CSSImageSetValue.cpp View 1 chunk +0 lines, -179 lines 0 comments Download
D sky/engine/core/css/CSSImageValue.h View 1 chunk +0 lines, -88 lines 0 comments Download
D sky/engine/core/css/CSSImageValue.cpp View 1 chunk +0 lines, -120 lines 0 comments Download
M sky/engine/core/css/CSSValue.h View 3 chunks +1 line, -9 lines 0 comments Download
M sky/engine/core/css/CSSValue.cpp View 8 chunks +0 lines, -28 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.h View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 6 chunks +1 line, -141 lines 0 comments Download
M sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/css/resolver/CSSToStyleMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/ElementStyleResources.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/resolver/ElementStyleResources.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResourceLoader.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 3 chunks +1 line, -32 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/HitTestResult.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderImageResourceStyleImage.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
D sky/engine/core/rendering/style/StyleFetchedImage.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/core/rendering/style/StyleFetchedImage.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
D sky/engine/core/rendering/style/StyleFetchedImageSet.h View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/engine/core/rendering/style/StyleFetchedImageSet.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
M sky/engine/core/rendering/style/StylePendingImage.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-05 20:07:24 UTC) #1
abarth-chromium
5 years, 5 months ago (2015-07-05 20:19:37 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0da6086b70ddc6b1a42da267532350f17fbd2d6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698