Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1214573004: [crankshaft] Remove adventurous operator< for Handle<Map>. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove adventurous operator< for Handle<Map>. This operator< overload is rather dangerous for handles. And we don't actually need a std::set in the chunk builder, since duplicates are automatically eliminated later when the code dependencies are committed. R=jarin@chromium.org Committed: https://crrev.com/d82c163de4a076632479a1916d4f147f5260d435 Cr-Commit-Position: refs/heads/master@{#29401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M src/handles.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/lithium.h View 3 chunks +4 lines, -8 lines 0 comments Download
M src/lithium.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-01 07:17:00 UTC) #1
Benedikt Meurer
Hey Jaro, No words necessary. Please take a look. Thanks, Benedikt
5 years, 5 months ago (2015-07-01 07:17:45 UTC) #2
Jarin
Awesome! lgtm.
5 years, 5 months ago (2015-07-01 07:23:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214573004/1
5 years, 5 months ago (2015-07-01 07:24:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 08:12:38 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 08:12:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d82c163de4a076632479a1916d4f147f5260d435
Cr-Commit-Position: refs/heads/master@{#29401}

Powered by Google App Engine
This is Rietveld 408576698