Chromium Code Reviews

Issue 1214533005: Convert gn_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
Marc-Antoine Ruel (Google), M-A Ruel, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert gn_unittests to run exclusively on Swarming 0 configs already ran on Swarming 3 used to run locally and were converted: - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) Ran: ./manage.py --convert gn_unittests BUG=98637 Committed: https://crrev.com/ddcc0a4109ccb62eeac7bd9eaf0efbc22412d8f8 Cr-Commit-Position: refs/heads/master@{#336929}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+28 lines, -3 lines)
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments
M tools/gn/gn.gyp View 1 chunk +15 lines, -0 lines 0 comments
A + tools/gn/gn_unittests.isolate View 2 chunks +4 lines, -3 lines 1 comment

Messages

Total messages: 10 (4 generated)
Nico
brettw: tools/gn maruel: testing/ https://codereview.chromium.org/1214533005/diff/20001/tools/gn/gn_unittests.isolate File tools/gn/gn_unittests.isolate (right): https://codereview.chromium.org/1214533005/diff/20001/tools/gn/gn_unittests.isolate#newcode12 tools/gn/gn_unittests.isolate:12: 'format_test_data/', (i filed https://code.google.com/p/chromium/issues/detail?id=505991 for ...
5 years, 5 months ago (2015-06-30 22:52:00 UTC) #2
Marc-Antoine Ruel (Google)
lgtm
5 years, 5 months ago (2015-06-30 22:57:49 UTC) #4
brettw
lgtm
5 years, 5 months ago (2015-06-30 23:19:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214533005/20001
5 years, 5 months ago (2015-06-30 23:52:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-01 00:19:54 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 00:20:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddcc0a4109ccb62eeac7bd9eaf0efbc22412d8f8
Cr-Commit-Position: refs/heads/master@{#336929}

Powered by Google App Engine